-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Credentials #2
base: main
Are you sure you want to change the base?
Conversation
Update ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (blocking): The PR introduces a new job to encode AZURE_*
secrets and pass them to subsequent jobs, yet GitHub Actions inherently supports the use of encrypted secrets directly in the workflow. GitHub Actions workflows have built-in support for securely handling secrets without the need for explicit encoding or intermediate steps. Given that the AZURE_*
secrets are already configured in the GitHub repository settings, the tests should be able to access these secrets directly, provided the necessary permissions are set. This raises the question of whether the additional complexity introduced by the credentials
job is necessary.
Set GitHub Secrets of Azure Credentials to environment variables