Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop basic/org workflows, standardize on enhanced #69

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

lkubb
Copy link
Member

@lkubb lkubb commented Oct 7, 2024

Drop org workflows

We decided we want to migrate away from the centralized (reusable) workflows in https://github.com/salt-extensions/central-artifacts for several reasons:

  • We want/need to use Trusted Publishing to limit blast radius inside the organization, which currently does not work with reusable workflows from outside the repository. It does however work with reusable workflows from within. We still need to think about how to implement this exactly.
  • Maintaining the centralized and the enhanced workflows is duplicate work. The centralized ones were intended to ensure automatically updating CI, but this is achieved via Copier as well.
  • Some extensions require specific setup, such as saltext-vault relying on the vault CLI to be available for testing. We cannot account for each requirement the way it's dealt with right now. Extension maintainers might also want to modify their CI in some way, which only works with workflows inside their repository.

Drop basic workflows

The basic workflows are a relict from the deprecated create-salt-extension tool. Let's drop them as well, they are strictly inferior to the enhanced ones.

Enforce supported Salt/Python versions only

Since the test matrices are autogenerated by the template, we additionally need to ensure the inputs (salt_version, max_salt_version, python_requires) are updated automatically when Salt releases are released or EOL'd.

Note: The version logic might need to be updated in the future since 3007 could be EOL'd before 3006 is.

@lkubb lkubb marked this pull request as ready for review October 7, 2024 12:34
@lkubb lkubb merged commit 6a7c0e8 into salt-extensions:main Oct 7, 2024
8 checks passed
@lkubb lkubb deleted the unify-workflows branch October 7, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant