Add vault_db modules
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkubb
force-pushed
the
vault-db
branch
3 times, most recently
from
eeb2f0a to
5fa3833
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
lkubb
force-pushed
the
vault-db
branch
6 times, most recently
from
413a0d6 to
26f08fb
Compare
lkubb
force-pushed
the
vault-db
branch
5 times, most recently
from
432057f to
3786f5a
Compare
lkubb
force-pushed
the
vault-db
branch
5 times, most recently
from
6e82b47 to
e19f72c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
vault_dbmodules for interfacing with the Database secret engine.vault_leasebeacon module to monitor and renew cached leases.The interface for cached database credentials is probably more complicated than necessary, but I wanted to keep this flexible since there is not enough learned experience to establish best practices.
If anyone wants to check this out and/or leave a review/some comments, you're always welcome. I'm going to leave this up a bit before merging.
What issues does this PR fix or reference?
Fixes: #52
Fixes: #53
Merge requirements satisfied?
Commits signed with GPG?
Yes