Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(environ): remove superfluous config dict #301

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

noelmcloughlin
Copy link
Member

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#294

Describe the changes you're proposing

This PR removes the config dictionary because environ and daemon_config are enough.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@noelmcloughlin noelmcloughlin changed the title Bug4 fix(environ): remove superfluous config dict Aug 24, 2021
@noelmcloughlin
Copy link
Member Author

Selfie merging as open 15 days without review.

@noelmcloughlin noelmcloughlin merged commit 67ba2af into saltstack-formulas:master Sep 8, 2021
@noelmcloughlin noelmcloughlin deleted the bug4 branch September 8, 2021 10:36
saltstack-formulas-travis pushed a commit that referenced this pull request Sep 8, 2021
# [2.2.0](v2.1.1...v2.2.0) (2021-09-08)

### Bug Fixes

* **coupling:** allow docker install without compose ([#298](#298)) ([aaedb00](aaedb00))
* **environ:** remove superfluous config dict ([#301](#301)) ([67ba2af](67ba2af))
* **windows:** change id to whoami ([#299](#299)) ([c0780ad](c0780ad))

### Features

* **limitnofile:** add support to systemd ([#302](#302)) ([299a1d0](299a1d0))
@saltstack-formulas-travis

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants