Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split maps.jinja #4

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Split maps.jinja #4

merged 2 commits into from
Feb 12, 2019

Conversation

alxwr
Copy link
Member

@alxwr alxwr commented Nov 28, 2018

  • into defaults, osfamilymap & osmap.
  • Added Raspbian support.

Tested on Raspbian GNU/Linux 9.6 (stretch).

- into defaults, osfamilymap & osmap.
- Added Raspbian support.
@alxwr alxwr requested a review from aboe76 November 28, 2018 11:57
@alxwr
Copy link
Member Author

alxwr commented Feb 12, 2019

@aboe76 Ping? :-)

@aboe76
Copy link
Member

aboe76 commented Feb 12, 2019

@alxwr can you use the newer map.jinja style from template-formula

@aboe76
Copy link
Member

aboe76 commented Feb 12, 2019

@alxwr by the way we created a master project in salt-formulas if you like to help:
https://github.com/orgs/saltstack-formulas/projects/1

@alxwr
Copy link
Member Author

alxwr commented Feb 12, 2019

@alxwr can you use the newer map.jinja style from template-formula

I would, if I was convinced it's compatible to salt-ssh. :-)
saltstack/salt#51605

Let's merge this PR now and edit map.jinja when #51605 has been resolved.

@alxwr by the way we created a master project in salt-formulas if you like to help:
https://github.com/orgs/saltstack-formulas/projects/1

I'll have a look from time to time. (I won't promise things I can't keep.) Thanks for mentioning it!

@aboe76 aboe76 merged commit bef5448 into saltstack-formulas:master Feb 12, 2019
@aboe76
Copy link
Member

aboe76 commented Feb 12, 2019

@alxwr ok perfect thanks

@myii
Copy link
Member

myii commented Feb 12, 2019

@alxwr I agree that we have to wait until the upstream bug has been resolved, unfortunately. In terms of a more general view of things, then saltstack-formulas/template-formula#21 is bit easier to follow for now!

@alxwr
Copy link
Member Author

alxwr commented Feb 12, 2019

@aboe76 Thanks for the merge!
@myii In the meantime we could use a map.jinja like in saltstack-formulas/openssh-formula#151 ? (At least it works. :-) )

@myii
Copy link
Member

myii commented Feb 12, 2019

@alxwr As always, PRs welcome!

@alxwr
Copy link
Member Author

alxwr commented Feb 12, 2019

@alxwr As always, PRs welcome!

Here you go: saltstack-formulas/template-formula#25 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants