Updating log_format in pillar.example #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This new format works well in |
|
@daks If you do get around to changing the tests to |
|
@garrettw Thanks for this. After #229 updated the test matrix, I was able to add another test to confirm this is working for all minions (in #231). Test results here: https://travis-ci.org/myii/nginx-formula/builds/524996941. |
|
🎉 This PR is included in version 0.56.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
aboe76
added a commit
that referenced
this pull request
Apr 27, 2019
test(inspec): add test for `log_format` #219
saltstack-formulas-travis
pushed a commit
that referenced
this pull request
Apr 27, 2019
## [0.56.1](v0.56.0...v0.56.1) (2019-04-27) ### Tests * **inspec:** add test for `log_format` [#219](#219) ([4ed788e](4ed788e))
blarghmatey
pushed a commit
to mitodl/nginx-formula
that referenced
this pull request
Dec 17, 2019
blarghmatey
pushed a commit
to mitodl/nginx-formula
that referenced
this pull request
Dec 17, 2019
## [0.56.1](saltstack-formulas/nginx-formula@v0.56.0...v0.56.1) (2019-04-27) ### Tests * **inspec:** add test for `log_format` [saltstack-formulas#219](saltstack-formulas#219) ([4ed788e](saltstack-formulas@4ed788e))
markbreedlove
pushed a commit
to mitodl/nginx-formula
that referenced
this pull request
Dec 17, 2019
markbreedlove
pushed a commit
to mitodl/nginx-formula
that referenced
this pull request
Dec 17, 2019
## [0.56.1](saltstack-formulas/nginx-formula@v0.56.0...v0.56.1) (2019-04-27) ### Tests * **inspec:** add test for `log_format` [saltstack-formulas#219](saltstack-formulas#219) ([4ed788e](saltstack-formulas@4ed788e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing changes discussed in #217.
The main issue that needs discussing/testing is whether the
access_logline (141 after this first commit) still needs to be part oflog_formatas a workaround (see #122) rather than just using the following line to specify it in YAML format.