Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textfile collector installation #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WiiPlayer2
Copy link

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The installation of textfile collectors is currently not part of testing which probably resulted in the installation being broken without realizing. This PR fixes template and installation issues regarding the textfile_collectors state and the provided collectors in this repository.

Pillar / config required to test the proposed changes

When running the kitchen tests, enable a collector in the pillar, and test e.g. debian-11-3004-0-py3

prometheus:
  exporters:
    node_exporter:
      textfile_collectors:
        ipmitool:
          enable: true

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Due to pillar key prometheus:exporters:node_exporter:textfile_collectors_dependencies being set to [] in the test pillar data, it overwrites the provided values for Debian in osfamilymap.yaml. To fully test this PR all OS families should declare the necessary textfile collector dependencies and the key should then be removed from the test pillar data.

@noelmcloughlin
Copy link
Member

Hi, thanks for PR. There are issues with commit messages, see https://github.com/conventional-changelog/commitlint/#what-is-commitlint so maybe fix/squash commits. i.e. fix(textfile): corrected the textfile collector installation

@WiiPlayer2 WiiPlayer2 force-pushed the fix-textfile-collectors branch from 17290ea to b1c9d22 Compare March 21, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants