Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serialization #17

Merged
merged 10 commits into from
Jan 25, 2025
Merged

Implement serialization #17

merged 10 commits into from
Jan 25, 2025

Conversation

AMythicDev
Copy link
Contributor

This PR brings all the work that I have done so far for serializing toml. By getting this merged, my intention is to take advantage of certain types already present in zig-toml.

This ts still a WIP so you can expect a lot of commits and I am not sure how I should go about with this. The two ways I can think of are:

  1. I make PRs for changes and occasionally you would accept all the final PRs.
  2. You can add be as a collaborator to this project with push permissions so that you don't have to bother with accepting PRs.

Let me know your opinions on this and then we can work it out accordingly.

Copy link
Owner

@sam701 sam701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I approved the actions for your PR. So the github check should always run after you push changes to this PR.

This ts still a WIP so you can expect a lot of commits and I am not sure how I should go about with this. The two ways I can think of are:

  1. I make PRs for changes and occasionally you would accept all the final PRs.
  2. You can add be as a collaborator to this project with push permissions so that you don't have to bother with accepting PRs.

I'd prefer to go with the first option, at least for a while - no offense.

src/serialize/root.zig Outdated Show resolved Hide resolved
@sam701
Copy link
Owner

sam701 commented Jan 18, 2025

@AMythicDev consider adding

comptime {
    _ = @import("./serialize/root.zig");
}

to ./src/tests.zig. Then the build check will run your tests. They are currently failing for zig-master.

@AMythicDev
Copy link
Contributor Author

Done

@sam701
Copy link
Owner

sam701 commented Jan 19, 2025

I see the check is failing. Are yo using the latest zig-master? What the check does is basically running zig build and zig build test.

@AMythicDev
Copy link
Contributor Author

I tried to fix all the issues. Can you re-run the CI?

@sam701
Copy link
Owner

sam701 commented Jan 22, 2025

@AMythicDev still failing. Did you run zig build and zig build test locally using the latest zig-master?

src/serialize/root.zig Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/serialize/root.zig Outdated Show resolved Hide resolved
src/serialize/root.zig Outdated Show resolved Hide resolved
src/serialize/root.zig Show resolved Hide resolved
src/serialize/root.zig Outdated Show resolved Hide resolved
@AMythicDev
Copy link
Contributor Author

I fixed all the errors in serialize module. The rest of the errors are because Zig v0.14.x has renamed default_value to default_value_ptr in StructField. It is used in the src/struct_mapping.zig file.

@sam701
Copy link
Owner

sam701 commented Jan 25, 2025

Great! All checks have passed 🚀 Merging now.... Thank you!

@sam701 sam701 merged commit 92f16dd into sam701:main Jan 25, 2025
1 check passed
@AMythicDev AMythicDev deleted the serialize branch January 25, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants