-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement serialization #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I approved the actions for your PR. So the github check should always run after you push changes to this PR.
This ts still a WIP so you can expect a lot of commits and I am not sure how I should go about with this. The two ways I can think of are:
- I make PRs for changes and occasionally you would accept all the final PRs.
- You can add be as a collaborator to this project with push permissions so that you don't have to bother with accepting PRs.
I'd prefer to go with the first option, at least for a while - no offense.
@AMythicDev consider adding comptime {
_ = @import("./serialize/root.zig");
} to |
Done |
I see the check is failing. Are yo using the latest zig-master? What the check does is basically running |
I tried to fix all the issues. Can you re-run the CI? |
@AMythicDev still failing. Did you run |
I fixed all the errors in serialize module. The rest of the errors are because Zig v0.14.x has renamed |
Great! All checks have passed 🚀 Merging now.... Thank you! |
This PR brings all the work that I have done so far for serializing toml. By getting this merged, my intention is to take advantage of certain types already present in zig-toml.
This ts still a WIP so you can expect a lot of commits and I am not sure how I should go about with this. The two ways I can think of are:
Let me know your opinions on this and then we can work it out accordingly.