Merge cockroachdb#129131

129131: changefeedccl: enable vmodule for TestAlterChangefeedAddTargetFamily r=rharding6373 a=andyyang890 This patch enables verbose logging (vmodule `helpers_test=1`) for `TestAlterChangefeedAddTargetFamily` so that we can get more information about what, if any, messages that the changefeed sees before the test times out. Informs cockroachdb#128749 Release note: None Co-authored-by: Andy Yang <[email protected]>
sambhav-jain-16 · Aug 20, 2024 · f1a5aa8 · f1a5aa8
2 parents cea6388 + 5a648d5
commit f1a5aa8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pkg/ccl/changefeedccl/alter_changefeed_test.go b/pkg/ccl/changefeedccl/alter_changefeed_test.go
@@ -240,6 +240,8 @@ func TestAlterChangefeedAddTargetFamily(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	defer log.Scope(t).Close(t)
 
+	require.NoError(t, log.SetVModule("helpers_test=1"))
+
 	testFn := func(t *testing.T, s TestServer, f cdctest.TestFeedFactory) {
 		sqlDB := sqlutils.MakeSQLRunner(s.DB)
 		sqlDB.Exec(t, `CREATE TABLE foo (a INT PRIMARY KEY, b STRING, FAMILY onlya (a), FAMILY onlyb (b))`)

diff --git a/pkg/ccl/changefeedccl/helpers_test.go b/pkg/ccl/changefeedccl/helpers_test.go
@@ -101,7 +101,7 @@ func readNextMessages(
 			return nil, ctx.Err()
 		}
 		if log.V(1) {
-			log.Infof(context.Background(), "About to read a message (%d out of %d)", len(actual), numMessages)
+			log.Infof(context.Background(), "about to read a message (%d out of %d)", len(actual), numMessages)
 		}
 		m, err := f.Next()
 		if log.V(1) {