Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crdb 29662 #2

Closed
wants to merge 339 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
339 commits
Select commit Hold shift + click to select a range
848a5df
rttanalysis: add benchmark for prisma types query
rafiss Aug 12, 2024
1ddc364
rac2: specify lock ordering, and add ReplicaSet
sumeerbhola Aug 9, 2024
3744a1c
go.mod: bump Pebble to 5627dafd7951
itsbilal Aug 12, 2024
80f7dbc
Merge #128754
Aug 12, 2024
954c5e1
roachtest: fix `admission-control/disk-bandwidth-limiter` on azure
aadityasondhi Aug 12, 2024
d2cd9f8
backup/restore: change documentation links to "stable"
benbardin Aug 12, 2024
5e6a854
Merge #128839
Aug 12, 2024
175a9db
sql: SHOW CREATE ALL TYPES doesn't work with comment on
Dedej-Bergin Jul 29, 2024
a6bcabc
roachtest: remove `autoupgrade` test
renatolabs Aug 12, 2024
0acacf2
Merge #128842
Aug 12, 2024
9e03322
clusterversion: create 24.3 version
RaduBerinde Aug 12, 2024
f6b88f5
Merge #128616 #128706
Aug 12, 2024
aff5d21
workload/schemachange: avoid commmenting on transient check constraints
rafiss Aug 12, 2024
55ed1c8
roachtest: Fix ycsb workload to avoid column families
navsetlur Aug 12, 2024
0c84c13
workload/schemachange: only allow PK change in single statement trans…
rafiss Aug 12, 2024
c4b1b74
schemachanger: remove unneeded function.
rafiss Aug 12, 2024
6bae06f
Merge #128833 #128834 #128851 #128855
Aug 12, 2024
fbda8dc
changefeedccl: attempt to deflake distribution strategy unit tests
andyyang890 Aug 12, 2024
1747b64
scripts/ldr: don't kill workload when stopped
dt Aug 12, 2024
5dbc891
Merge #128084 #128715
Aug 12, 2024
a8b016c
Merge #128857
Aug 13, 2024
6e1ead5
sqlstats: add close chan to buffer ingester
dhartunian Aug 9, 2024
9765a2c
Merge #128713
Aug 13, 2024
7c627b8
kvserver: fix empty lease logging
tbg Aug 13, 2024
fa3d0f9
kvserver: log status when lease requested
tbg Aug 13, 2024
48834e9
Merge #128447
Aug 13, 2024
7cdceb5
rpc: add Locality to dialing
andrewbaptist Jun 24, 2024
8dbb70b
rpc: add Locality to the ContextOptions
andrewbaptist Jun 27, 2024
54afa00
rpc: add Locality to UnvalidatedDial
andrewbaptist Jun 26, 2024
1ce295d
rpc: extract constant for expected count
andrewbaptist Jun 27, 2024
b43ef26
rpc: add metrics for connected count and bytes sent
andrewbaptist Jun 27, 2024
2451613
rpc: make the roundTripLatency metric threadsafe
andrewbaptist Jul 2, 2024
fd1b0b2
crosscluster/logical: add job ID to application name
stevendanna Aug 6, 2024
9da7cd6
workload/schemachanger: re-enable DROP SCHEMA
spilchen Aug 13, 2024
1e8073b
Merge #128812
Aug 13, 2024
5592437
storeliveness: supporter and requester models and transitions
miraradeva Jul 16, 2024
34658a5
Merge #128705
Aug 13, 2024
77c253b
insights: ensure releasing to Insight pool clears slice
xinhaoz Aug 9, 2024
c9f233b
Merge #128873
Aug 13, 2024
3405736
Merge #128846
Aug 13, 2024
bb2613e
Merge #128874
Aug 13, 2024
daf39c2
sql: revert multiple partial stats requests error to a pgerror
Uzair5162 Aug 12, 2024
875fd2f
sql: enforce statement_timeout when waiting for jobs during commit
fqazi Aug 7, 2024
1543e27
raft: include LeadEpoch when printing out HardState
arulajmani Aug 9, 2024
e25886d
Merge #128474
Aug 13, 2024
75fb4fa
roachprod: more clearly log DestroyCluster progress
DarrylWong Aug 12, 2024
b34d0e1
rpc: pass Metrics by pointer
andrewbaptist Jun 25, 2024
a7e583c
rpc: more precise peer metrics
andrewbaptist Jun 27, 2024
0de64fc
crosscluster/logical: store previously seen addresses
stevendanna Jul 22, 2024
ed6841f
rpc: retain metrics in a map
andrewbaptist Jun 27, 2024
ed0cad0
Merge #128862
Aug 13, 2024
3ec1740
Merge #127262
Aug 13, 2024
d471ff9
kv: support gradual rollout of Leader leases
nvanbenschoten Aug 9, 2024
f7013c3
Merge #128483 #128858
Aug 13, 2024
66f6567
Merge #127613 #128815
Aug 13, 2024
63401ac
workload/schemachanger: fix create index concurrently with drop column
fqazi Aug 13, 2024
83c5c25
sql: avoid large timeout in test
rafiss Aug 13, 2024
467aeae
Merge #128921
Aug 13, 2024
f01b504
sqlstats; don't redact informational log message
rafiss Aug 9, 2024
fa26668
sql/schemachanger: fix flake inside TestConcurrentSchemaChanges
fqazi Aug 13, 2024
37a37b0
Merge #128918
Aug 13, 2024
9d8b94f
rpc: allow splitting network stats by locality
andrewbaptist Jun 25, 2024
91243c1
Merge #128689 #128832
Aug 13, 2024
51a7038
lease: deflake TestLeaseAtLatestVersion
rafiss Aug 13, 2024
79f28f5
catalog: rename ByID to ByIDWithoutLeased
rafiss Aug 13, 2024
e02199c
Merge #128929
Aug 13, 2024
23f9b47
rpc: skip TestTenantGRPCServices under stress
andrewbaptist Aug 13, 2024
0671da8
insights: add testing knobs
xinhaoz Aug 9, 2024
e0431e0
sqlstats/insights: free memory allocated per session on session close
xinhaoz Aug 5, 2024
667785c
Merge #126150
Aug 14, 2024
9e25799
sql: fix TestRandomSyntaxSchemaChangeDatabase flake
fqazi Aug 14, 2024
5892efb
raft: update LeadEpoch in response to MsgFortify
arulajmani Aug 12, 2024
3e07f42
raft: include LeadEpoch in MsgStorageAppend
arulajmani Aug 13, 2024
abe3d27
Merge #128845
Aug 14, 2024
5ea19b8
Merge #128775
Aug 14, 2024
3b43ad5
roachtest: online restore with unsafe_incompatible_version
msbutler Aug 14, 2024
d8df4a4
workload/schemachange: temp disable alterPK
annrpom Aug 14, 2024
3489e33
roachtest: add 24.3 min version to multitenant-upgrade
msbutler Aug 14, 2024
ac2d86d
Merge #128962
Aug 14, 2024
69d8812
kvserver: skip rebalance multi-store under deadlock
kvoli Aug 14, 2024
8105594
crosscluster/logical: replan with correct asOf time
stevendanna Aug 12, 2024
78a0ccf
roachprod: stop `update` calls on platforms other than linux
renatolabs Aug 14, 2024
aa21162
Merge #128963
Aug 14, 2024
b4a9870
Merge #128939 #128961
Aug 14, 2024
4cdf0b9
sql/sem/builtins: validate engine keys in storage builtins
jbowens Aug 13, 2024
5be64d8
Merge #128966
Aug 14, 2024
2da6863
insights: move insights testing knobs from sqlstats
xinhaoz Aug 9, 2024
596605b
raft: remove punctuation from log line
nvanbenschoten Aug 14, 2024
e35dc31
raft: log on ignored MsgForgetLeader
nvanbenschoten Aug 14, 2024
4294b18
Merge #128967
Aug 14, 2024
1a0a4c9
raft: consult StoreLiveness when handling MsgFortify
arulajmani Aug 14, 2024
ce38cdb
roachtest: backup-restore/mixed-version support for shared-process
renatolabs Jul 12, 2024
7723dda
logictest: ignore "Can't find decompressor for snappy" error
rafiss Aug 14, 2024
0b7eb88
sql/sem/tree: remove duplicate `tree.NewDOidWithName` function
mgartner Aug 14, 2024
5a71881
log: remove STRUCTURED_EVENT logging channel
kyle-a-wong Aug 14, 2024
337034b
Merge #128935 #128984
Aug 14, 2024
b33e5e8
sql/randgen: do not generate expressions of type FLOAT4
mgartner Aug 14, 2024
7ce7cde
roachprod: azure destroy cluster returns error if no resource group w…
DarrylWong Aug 14, 2024
93daeb4
kvserver: split snapshot SSTables for mvcc keys into multiple SSTs
itsbilal Jul 31, 2024
e5eb944
Merge #127997
Aug 14, 2024
375d615
kvflowcontrolpb,kvserverpb: add AdmittedResponseForRange
sumeerbhola Aug 14, 2024
da63cd6
ui: Fix columnsSelector CSS safari issue
kyle-a-wong Aug 14, 2024
5fd1f15
clusterversion: allow skip-version upgrade without env var
renatolabs Aug 14, 2024
12a2e6d
Revert "roachtest: online restore with unsafe_incompatible_version"
renatolabs Aug 14, 2024
e5c3a30
restore: only run proc lag checker on fully updgraded 24.3 clusters
msbutler Aug 13, 2024
b903b22
Merge #128969
Aug 14, 2024
74cc8e2
raft: respect leader fortification in MsgForgetLeader
nvanbenschoten Aug 14, 2024
739cc7d
Merge #128696 #128931
Aug 14, 2024
9421149
Merge #129000
Aug 14, 2024
7cd4295
raft: send follower's commit index in MsgAppResp
iskettaneh Aug 7, 2024
b6c7012
Merge #128843 #128932 #128985 #128988
Aug 14, 2024
ff3e604
Merge #128497
Aug 14, 2024
d84ff40
sql/logictest: deflake schema_change_in_txn
mgartner Aug 14, 2024
2a0ba6a
Merge #128859
Aug 14, 2024
345a3a5
crosscluster/logical: prevent data looping with kv writer
dt Aug 14, 2024
575cdd4
Merge #129013
Aug 14, 2024
c536d31
replica_rac2: add Processor, that integrates RangeController with kvs…
sumeerbhola Aug 9, 2024
ffab619
sqlsmith: limit attempts to generate operators
rharding6373 Aug 14, 2024
4a293c6
Merge #128777
Aug 15, 2024
20dd32f
crosscluster/logical: deflake TestRandomTable
stevendanna Aug 8, 2024
67b2617
Merge #128378
Aug 15, 2024
4cab40a
Merge #128579
Aug 15, 2024
a0d23d2
Merge #128927
Aug 15, 2024
ed908fa
Merge #128926
Aug 15, 2024
c7291e2
Merge #128983
Aug 15, 2024
ee78f90
kvnemesis: properly skip validation for rolled-back locking reads in …
miraradeva Aug 12, 2024
9e09631
sql: add SHOW LOGICAL REPLICATION JOBS syntax
azhu-crl Aug 13, 2024
51a51d8
sql/schemachanger: move column compute expression to separate DSC ele…
spilchen Aug 15, 2024
2760ba0
Merge #129016
Aug 15, 2024
f4d85c1
util: add utility to process CIDR records
andrewbaptist Jul 10, 2024
e3a02e1
sql: propagate the cidr.Lookup into ExecutorConfig
andrewbaptist Jul 12, 2024
636b464
sql: pass an Inc function to writeBuffer
andrewbaptist Aug 14, 2024
806cd73
Merge #128387
Aug 15, 2024
2e01925
sql: restructure sql byte metrics to be add metrics
andrewbaptist Jul 12, 2024
454d3ad
storeliveness: persist support state and metas
miraradeva Aug 13, 2024
4c234ad
changefeedccl: disambiguate kv buffer metrics & logs
asg0451 Aug 12, 2024
fe49f7c
Merge #128813 #128847 #128982 #129020
Aug 15, 2024
1561adf
Merge #128928
Aug 15, 2024
47d19a3
roachtest: allow callers to set skip-version probability
renatolabs Aug 15, 2024
5a21595
roachtest: make graceful stop an option instead of a function
renatolabs Aug 12, 2024
4584f4c
Merge #128707 #128892
Aug 15, 2024
0801a13
kvserver: disable snapshot splitting of sstables for now
itsbilal Aug 15, 2024
30cb162
Merge #128996
Aug 15, 2024
237a885
clusterversion: clean up deprecated gates
RaduBerinde Aug 15, 2024
4336e64
Merge #128992
Aug 15, 2024
a675cc7
schemachanger: support NaN/Inf as a default value in a function
rafiss Aug 14, 2024
037b558
util: fix return values for cidr http
andrewbaptist Aug 15, 2024
a5b8e0c
Merge #128849 #129063
Aug 15, 2024
7983e80
Merge #128820
Aug 15, 2024
5df8e6b
roachtest: deflake `admission-control/disk-bandwidth-limiter` on azure
aadityasondhi Aug 15, 2024
0a82776
opt: fix resolution of CHECK expressions for ENUM expression indexes
mgartner Aug 15, 2024
ab496aa
Merge #129019 #129075
Aug 15, 2024
886533f
roachtest: multi-region/mixed-version support for shared-process
renatolabs Aug 15, 2024
103bd54
Reapply "bootstrap: create an explicit zoneconfig for timeseries data"
rafiss Jul 30, 2024
0ae91a1
upgrades: create a timeseries zone config during upgrade
rafiss Aug 13, 2024
5907123
Merge #129080
Aug 15, 2024
f9e0f16
sql/parser: only retain scanned SQL comments when necessary
mgartner Aug 15, 2024
7b3e097
Merge #128987
Aug 15, 2024
6f97e36
go.mod: bump Pebble to 1010734315f6
RaduBerinde Aug 15, 2024
ec66ae7
Merge #128032 #129053
Aug 15, 2024
7ba272f
workload: mark more schema change ops as supported in declarative
rafiss Aug 14, 2024
93b540c
workload/schemachange: avoid using legacy schema changer for DSC ops
rafiss Aug 14, 2024
86708bb
sqlliveness: handle AmbiguousResultError gracefully on insert
fqazi Aug 13, 2024
b4fedbe
Merge #128550
Aug 16, 2024
361d693
Merge #128930
Aug 16, 2024
36e491f
roachtest: deflake mt upgrade test
msbutler Aug 16, 2024
53abc48
roachtest: mixedversion documentation updates
renatolabs Aug 15, 2024
2129f58
roachtest: include step ID in failures to get debug information
renatolabs Aug 16, 2024
8432222
Merge #129064
Aug 16, 2024
e13e75c
roachtest: update rebalance-load mixed-version tests for shared-process
renatolabs Jul 11, 2024
40943c6
crosscluster/logical: commit-in-batch single row in kv writer
dt Aug 15, 2024
56fac6d
node_rac2: add AdmittedPiggybacker and use in RaftTransport
sumeerbhola Aug 15, 2024
ef16081
kvserver: reenable splitting of snapshot sstables
itsbilal Aug 15, 2024
439dd46
Merge #129118
Aug 16, 2024
f80bc8a
Merge #129081
Aug 16, 2024
5a648d5
changefeedccl: enable vmodule for TestAlterChangefeedAddTargetFamily
andyyang890 Aug 16, 2024
bdfba7a
Merge #129088
Aug 16, 2024
03861f5
workload/schemachange: make column default errors more lenient
annrpom Aug 16, 2024
9b3d3cd
go.mod: bump Pebble to ac08db2964cd
jbowens Aug 16, 2024
82f27a1
Merge #129099 #129115
Aug 16, 2024
a68ebba
ui: bump cluster-ui to 24.3.0-prerelease.0
dhartunian Aug 16, 2024
c171b3e
crosscluster/logical: add fallback to SQL to kv writer
dt Aug 15, 2024
41b3043
Merge #129124
Aug 16, 2024
0c74c3f
Merge #129143
Aug 16, 2024
9dd71dc
Merge #129116
Aug 16, 2024
9e84135
eval: fix hlc_to_timestamp builtin
michae2 Aug 16, 2024
446bc36
Merge #129153
Aug 16, 2024
657ae17
admission,kvserver: plumbing for RACv2 callbacks
sumeerbhola Aug 16, 2024
1993fc0
Merge #128400
Aug 17, 2024
16cd566
sql: don't allow VOID parameters for UDFs
rafiss Aug 17, 2024
b4d3ef5
build: update errcheck
RaduBerinde Aug 19, 2024
215754e
cli: update cluster tag in tsdump upload
aa-joshi Aug 19, 2024
33e2197
Merge #129213
Aug 19, 2024
c14f0e1
kvserver/rangefeed: change p.Register to use registration interface
wenyihu6 Jul 30, 2024
2bb3625
kvserver/rangefeed: move perRangeEventSink to rangefeed pacakge
wenyihu6 Aug 17, 2024
e75a165
Merge #128902
Aug 19, 2024
b0599de
Merge #129089
Aug 19, 2024
e7b031d
workload/schemachange: be more lenient for DROP DEFAULT error code
rafiss Aug 19, 2024
97dab43
Merge #128986 #129079 #129236
Aug 19, 2024
716faf0
logictest: deflake cross_version_tenant_backup
rafiss Aug 19, 2024
e105162
roachtest: upgrade hibernate version under test
rafiss Aug 19, 2024
1c75c25
ui: remove unnecessary metric name prefixes
dhartunian Aug 16, 2024
14c0bf9
Merge #129128
Aug 19, 2024
44a0a3d
roachprod: azure GC supports cleanup for multiple subscriptions
DarrylWong Aug 15, 2024
947f842
workflows: enable CI for GitHub merge queue builds
rickystewart Aug 19, 2024
09a29c8
Merge #129207
Aug 19, 2024
ce2d56d
backupccl: remove not null flag from SQLInstanceID field in SSP spec
msbutler Aug 19, 2024
102449b
Merge #129251
Aug 19, 2024
79cac09
Merge #129252
Aug 19, 2024
ed6e625
kvcoord: safe format replica slice
kvoli Aug 19, 2024
d63e870
kvcoord: log replica order on nearest routing policy
kvoli Aug 19, 2024
9a7545b
Merge #129264
Aug 19, 2024
548b957
Merge #129179
Aug 19, 2024
852676d
kvserver: misc partial wiring for RACv2
sumeerbhola Aug 17, 2024
6cade02
Merge #129243
Aug 19, 2024
ac393cd
Merge #129127
Aug 19, 2024
2dd4df9
rac2: implement wait for eval helper
kvoli Aug 14, 2024
db988b3
dev: add temporary directory in sandbox for `compose`
rickystewart Aug 19, 2024
f5e3b37
Merge #129262
Aug 19, 2024
9da323e
Merge #129282
Aug 19, 2024
5972907
Merge #128998
Aug 19, 2024
b0e1aaa
ui: display very large ranges in problematic ranges
iskettaneh Aug 14, 2024
6180c0c
Merge #129241
Aug 20, 2024
3843a7d
master: Update pkg/testutils/release/cockroach_releases.yaml
cockroach-teamcity Aug 20, 2024
ec9e227
Merge #129290
Aug 20, 2024
ba7c94a
Merge #129227
Aug 20, 2024
69da7de
roachtest: use spot VM for all tests
nameisbhaskar Jul 30, 2024
d4987a5
lease: fix goroutine starvation caused by test cluster setting
rafiss Aug 20, 2024
b31a6ae
roachprod: reuse start script if start is called with --restart=true
vidit-bhat Aug 13, 2024
3894961
Merge #128898
Aug 20, 2024
b42ad64
Merge #127896
Aug 20, 2024
7379814
Merge #129001
Aug 20, 2024
8296213
Merge #129085
Aug 20, 2024
d5329dc
Merge #123848 #129117 #129302
Aug 20, 2024
7e59ad4
go.mod: bump Pebble to 3d14906a0e0c
jbowens Aug 20, 2024
7aa5ca0
kv: fix comment on QueryTxnResponse.QueriedTxn
nvanbenschoten Aug 20, 2024
8018ff7
crosscluster, sql: implement SHOW LOGICAL REPLICATION JOBS
azhu-crl Aug 15, 2024
f985c4f
kvserver: deflake TestRangefeedCheckpointsRecoverFromLeaseExpiration
iskettaneh Aug 19, 2024
01c7aad
Merge #129279
Aug 20, 2024
85e85d7
Merge #129331
Aug 20, 2024
333e528
Merge #129333
Aug 20, 2024
ee0510d
Merge #129095
Aug 20, 2024
51d607b
changefeedccl: add more logging around core changefeed completion
andyyang890 Aug 20, 2024
7557486
Merge #129335
Aug 20, 2024
ebefe41
Merge #129149
Aug 20, 2024
27dc4e6
Merge #129058
Aug 20, 2024
d967d94
kvclient: improve logging in OptimizeReplicaOrder
arulajmani Aug 20, 2024
cea6388
Merge #129368
Aug 20, 2024
f1a5aa8
Merge #129131
Aug 20, 2024
e2b7b6c
workflows: disable cockroach-microbench-ci step for pull requests
sambhav-jain-16 Aug 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
39 changes: 19 additions & 20 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@

/pkg/sql/crdb_internal.go @cockroachdb/sql-foundations
/pkg/sql/pg_catalog.go @cockroachdb/sql-foundations
/pkg/sql/pgwire/ @cockroachdb/sql-foundations @cockroachdb/server-prs
/pkg/sql/pgwire/ @cockroachdb/sql-foundations @cockroachdb/server-prs @cockroachdb/product-security
/pkg/sql/pgwire/auth.go @cockroachdb/sql-foundations @cockroachdb/server-prs @cockroachdb/prodsec
/pkg/sql/sem/builtins/ @cockroachdb/sql-foundations
/pkg/sql/vtable/ @cockroachdb/sql-foundations
Expand Down Expand Up @@ -125,8 +125,8 @@
# functionality into sub-packages assigned to their respective teams.
#
#!/pkg/cli/ @cockroachdb/unowned
/pkg/cli/auth.go @cockroachdb/prodsec @cockroachdb/cli-prs
/pkg/cli/cert*.go @cockroachdb/prodsec @cockroachdb/cli-prs
/pkg/cli/auth.go @cockroachdb/prodsec @cockroachdb/cli-prs @cockroachdb/product-security
/pkg/cli/cert*.go @cockroachdb/prodsec @cockroachdb/cli-prs @cockroachdb/product-security
/pkg/cli/cli.go @cockroachdb/cli-prs
/pkg/cli/cli_debug*.go @cockroachdb/kv-prs @cockroachdb/cli-prs
/pkg/cli/cli_test.go @cockroachdb/cli-prs
Expand All @@ -152,7 +152,7 @@
/pkg/cli/inflight_trace_dump/ @cockroachdb/obs-prs @cockroachdb/cli-prs @cockroachdb/obs-india-prs
/pkg/cli/init.go @cockroachdb/kv-prs @cockroachdb/cli-prs
/pkg/cli/log*.go @cockroachdb/obs-prs @cockroachdb/cli-prs @cockroachdb/obs-india-prs
/pkg/cli/mt_cert* @cockroachdb/prodsec
/pkg/cli/mt_cert* @cockroachdb/prodsec @cockroachdb/product-security
/pkg/cli/mt_proxy.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
/pkg/cli/mt_start_sql.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
/pkg/cli/mt_test_directory.go @cockroachdb/sqlproxy-prs @cockroachdb/server-prs
Expand All @@ -177,8 +177,8 @@
#!/pkg/server/ @cockroachdb/unowned
/pkg/server/admin*.go @cockroachdb/obs-prs @cockroachdb/server-prs
/pkg/server/api_v2*.go @cockroachdb/obs-prs @cockroachdb/server-prs
/pkg/server/api_v2_auth*.go @cockroachdb/obs-prs @cockroachdb/server-prs @cockroachdb/prodsec
/pkg/server/authentication*.go @cockroachdb/prodsec @cockroachdb/server-prs
/pkg/server/api_v2_auth*.go @cockroachdb/obs-prs @cockroachdb/server-prs @cockroachdb/prodsec @cockroachdb/product-security
/pkg/server/authentication*.go @cockroachdb/prodsec @cockroachdb/server-prs @cockroachdb/product-security
/pkg/server/clock_monotonicity.go @cockroachdb/kv-prs
/pkg/server/combined_statement_stats*.go @cockroachdb/obs-prs
/pkg/server/critical_nodes*.go @cockroachdb/obs-prs
Expand Down Expand Up @@ -217,7 +217,7 @@
/pkg/server/server_obs* @cockroachdb/obs-prs
/pkg/server/server_systemlog* @cockroachdb/obs-prs
/pkg/server/serverpb/ @cockroachdb/obs-prs @cockroachdb/server-prs
/pkg/server/serverpb/authentication* @cockroachdb/obs-prs @cockroachdb/prodsec @cockroachdb/server-prs
/pkg/server/serverpb/authentication* @cockroachdb/obs-prs @cockroachdb/prodsec @cockroachdb/server-prs @cockroachdb/product-security
/pkg/server/serverpb/index_reco* @cockroachdb/obs-prs
/pkg/server/serverrules/ @cockroachdb/obs-prs @cockroachdb/server-prs
/pkg/server/settings_cache*.go @cockroachdb/server-prs
Expand All @@ -236,7 +236,7 @@
/pkg/server/tenantsettingswatcher/ @cockroachdb/server-prs
/pkg/server/testserver*.go @cockroachdb/test-eng @cockroachdb/server-prs
/pkg/server/tracedumper/ @cockroachdb/obs-prs @cockroachdb/server-prs
/pkg/server/user*.go @cockroachdb/obs-prs @cockroachdb/server-prs @cockroachdb/prodsec
/pkg/server/user*.go @cockroachdb/obs-prs @cockroachdb/server-prs @cockroachdb/prodsec @cockroachdb/product-security
/pkg/server/version_cluster*.go @cockroachdb/dev-inf


Expand Down Expand Up @@ -378,23 +378,23 @@
/pkg/ccl/cmdccl/stub-schema-registry/ @cockroachdb/cdc-prs
/pkg/ccl/cmdccl/clusterrepl/ @cockroachdb/disaster-recovery
/pkg/ccl/gqpccl/ @cockroachdb/sql-queries-prs
#!/pkg/ccl/gssapiccl/ @cockroachdb/unowned
/pkg/ccl/jwtauthccl/ @cockroachdb/cloud-identity
/pkg/ccl/gssapiccl/ @cockroachdb/product-security
/pkg/ccl/jwtauthccl/ @cockroachdb/cloud-identity @cockroachdb/product-security
#!/pkg/ccl/kvccl/ @cockroachdb/kv-noreview
/pkg/ccl/kvccl/kvtenantccl/ @cockroachdb/server-prs
/pkg/ccl/ldapccl/ @cockroachdb/prodsec
/pkg/ccl/ldapccl/ @cockroachdb/prodsec @cockroachdb/product-security
#!/pkg/ccl/upgradeccl/ @cockroachdb/release-eng-prs @cockroachdb/upgrade-prs
#!/pkg/ccl/logictestccl/ @cockroachdb/sql-queries-noreview
#!/pkg/ccl/sqlitelogictestccl/ @cockroachdb/sql-queries-noreview
/pkg/ccl/multiregionccl/ @cockroachdb/sql-foundations
/pkg/ccl/multitenantccl/ @cockroachdb/server-prs
/pkg/ccl/multitenant/tenantcostclient/ @cockroachdb/sqlproxy-prs
/pkg/ccl/multitenant/tenantcostserver/ @cockroachdb/sqlproxy-prs
/pkg/ccl/oidcccl/ @cockroachdb/obs-prs
/pkg/ccl/oidcccl/ @cockroachdb/product-security
/pkg/ccl/partitionccl/ @cockroachdb/sql-foundations
/pkg/ccl/pgcryptoccl/ @cockroachdb/sql-foundations
/pkg/ccl/plpgsqlccl/ @cockroachdb/sql-queries-prs

/pkg/ccl/securityccl/ @cockroachdb/prodsec @cockroachdb/product-security
#!/pkg/ccl/serverccl/ @cockroachdb/unowned
/pkg/ccl/serverccl/diagnosticsccl/ @cockroachdb/obs-prs
/pkg/ccl/serverccl/server_sql* @cockroachdb/server-prs
Expand All @@ -407,7 +407,7 @@

/pkg/ccl/telemetryccl/ @cockroachdb/obs-prs

/pkg/ccl/testccl/authccl/ @cockroachdb/cloud-identity @cockroachdb/prodsec
/pkg/ccl/testccl/authccl/ @cockroachdb/cloud-identity @cockroachdb/prodsec @cockroachdb/product-security
/pkg/ccl/testccl/sqlccl/ @cockroachdb/sql-queries-prs
/pkg/ccl/testccl/workload/schemachange/ @cockroachdb/sql-foundations
#!/pkg/ccl/testutilsccl/ @cockroachdb/test-eng-noreview
Expand All @@ -416,6 +416,7 @@
/pkg/ccl/workloadccl/ @cockroachdb/test-eng #! @cockroachdb/sql-foundations-noreview
/pkg/ccl/benchccl/rttanalysisccl/ @cockroachdb/sql-foundations
#!/pkg/clusterversion/ @cockroachdb/dev-inf-noreview @cockroachdb/kv-prs-noreview @cockroachdb/test-eng-prs
/pkg/clusterversion/cockroach_versions.go @cockroachdb/release-eng-prs @cockroachdb/upgrade-prs
/pkg/cmd/allocsim/ @cockroachdb/kv-prs
/pkg/cmd/bazci/ @cockroachdb/dev-inf
/pkg/cmd/cloudupload/ @cockroachdb/dev-inf
Expand Down Expand Up @@ -458,7 +459,6 @@
/pkg/cmd/release/ @cockroachdb/dev-inf
/pkg/cmd/returncheck/ @cockroachdb/dev-inf
/pkg/cmd/roachprod/ @cockroachdb/test-eng
/pkg/cmd/roachprod/vm/azure/auth.go @cockroachdb/test-eng @cockroachdb/prodsec
/pkg/cmd/roachprod-microbench/ @cockroachdb/test-eng
/pkg/cmd/roachprod-stress/ @cockroachdb/test-eng
/pkg/cmd/roachtest/ @cockroachdb/test-eng
Expand Down Expand Up @@ -539,12 +539,11 @@
#!/pkg/roachpb/version* @cockroachdb/unowned
/pkg/roachprod/ @cockroachdb/test-eng
/pkg/rpc/ @cockroachdb/kv-prs
/pkg/rpc/auth.go @cockroachdb/kv-prs @cockroachdb/prodsec
/pkg/rpc/auth_tenant.go @cockroachdb/server-prs @cockroachdb/prodsec
/pkg/rpc/auth.go @cockroachdb/kv-prs @cockroachdb/prodsec @cockroachdb/product-security
/pkg/rpc/auth_tenant.go @cockroachdb/server-prs @cockroachdb/prodsec @cockroachdb/product-security
/pkg/scheduledjobs/ @cockroachdb/jobs-prs @cockroachdb/disaster-recovery
/pkg/security/ @cockroachdb/prodsec @cockroachdb/server-prs
/pkg/security/clientsecopts/ @cockroachdb/sql-foundations @cockroachdb/prodsec
/pkg/ccl/securityccl/ @cockroachdb/prodsec
/pkg/security/ @cockroachdb/prodsec @cockroachdb/server-prs @cockroachdb/product-security
/pkg/security/clientsecopts/ @cockroachdb/sql-foundations @cockroachdb/prodsec @cockroachdb/product-security
#!/pkg/settings/ @cockroachdb/unowned
/pkg/spanconfig/ @cockroachdb/kv-prs @cockroachdb/sql-foundations
/pkg/spanconfig/spanconfigbounds/ @cockroachdb/sql-foundations
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/github-actions-essential-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ on:
- "!staging-v23.2*"
push:
branches:
- "gh-readonly-queue/*"
- "master"
- "release-*"
- "staging-*"
Expand Down Expand Up @@ -346,6 +347,8 @@ jobs:
if: always()
cockroach-microbench-ci:
runs-on: [ self-hosted, basic_runner_group ]
# TODO(sambhav-jain-16): enable this for pull requests also
if: ${{ github.event_name == 'push' }}
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
Expand All @@ -369,6 +372,7 @@ jobs:

# Set the latest commit hash as an output variable
echo "::set-output name=latest_commit::$LATEST_COMMIT"
if: ${{ github.event_name != 'push' }}
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
Expand All @@ -380,11 +384,11 @@ jobs:
run: ./build/github/cockroach-microbench-ci.sh
env:
COMPARE_THRESHOLD: "5.00"
PUSH_STEP: ${{ github.event_name == 'push' }}
PUSH_STEP: ${{ github.event_name == 'push' && env.GITHUB_ACTIONS_BRANCH != 'staging' }}
BASE_SHA: ${{ steps.get_latest_commit_target_branch.outputs.latest_commit }}

# TODO(sambhav-jain-16): add Performance note check and use this flag. Currently set to false (https://github.com/cockroachdb/cockroach/issues/106661)
SKIP_COMPARISON: false
SKIP_COMPARISON: ${{ env.GITHUB_ACTIONS_BRANCH == 'staging' }}
- name: upload build results
run: ./build/github/summarize-build.sh bes.bin
if: always()
Expand Down
18 changes: 9 additions & 9 deletions DEPS.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1625,10 +1625,10 @@ def go_deps():
name = "com_github_cockroachdb_crlib",
build_file_proto_mode = "disable_global",
importpath = "github.com/cockroachdb/crlib",
sha256 = "75022b33828ba2c915827a3e217ea5d19bd1e7c6aa702b344cf3d349ae7f31b4",
strip_prefix = "github.com/cockroachdb/[email protected]20240729155931-991150b7e290",
sha256 = "ab49848ce4daea2599f91fd17942826bf62532b6d71af8bf8a02f4dff97118f3",
strip_prefix = "github.com/cockroachdb/[email protected]20240816115810-1c502cdb7c1d",
urls = [
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/crlib/com_github_cockroachdb_crlib-v0.0.0-20240729155931-991150b7e290.zip",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/crlib/com_github_cockroachdb_crlib-v0.0.0-20240816115810-1c502cdb7c1d.zip",
],
)
go_repository(
Expand Down Expand Up @@ -1718,10 +1718,10 @@ def go_deps():
patches = [
"@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch",
],
sha256 = "364fa399a7b5479feaf2af30cb833cb1aac153d5aec05df0d63f24c3b4d58299",
strip_prefix = "github.com/cockroachdb/[email protected]20240801172554-a466dadd19f0",
sha256 = "d599fcb2be858abbdf59fd73b09b214650b8b1d3883bf90d509a998849baa699",
strip_prefix = "github.com/cockroachdb/[email protected]20240820151534-3d14906a0e0c",
urls = [
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20240801172554-a466dadd19f0.zip",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20240820151534-3d14906a0e0c.zip",
],
)
go_repository(
Expand Down Expand Up @@ -5526,10 +5526,10 @@ def go_deps():
patches = [
"@com_github_cockroachdb_cockroach//build/patches:com_github_kisielk_errcheck.patch",
],
sha256 = "99d3220891162cb684f8e05d54f3d0dc58abdd496a2f0cfda7fd4a28917a719e",
strip_prefix = "github.com/kisielk/errcheck@v1.6.1-0.20210625163953-8ddee489636a",
sha256 = "f394d1df1f2332387ce142d98734c5c44fb94e9a8a2af2a9b75aa4ec4a64b963",
strip_prefix = "github.com/kisielk/errcheck@v1.7.0",
urls = [
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kisielk/errcheck/com_github_kisielk_errcheck-v1.6.1-0.20210625163953-8ddee489636a.zip",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kisielk/errcheck/com_github_kisielk_errcheck-v1.7.0.zip",
],
)
go_repository(
Expand Down
2 changes: 2 additions & 0 deletions TEAMS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ cockroachdb/security:
label: T-cross-product-security
cockroachdb/prodsec:
label: T-cross-product-security
cockroachdb/product-security:
label: T-product-security
cockroachdb/disaster-recovery:
triage_column_id: 3097123
label: T-disaster-recovery
Expand Down
2 changes: 1 addition & 1 deletion build/bazelbuilder/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# We use a docker image mirror to avoid pulling from 3rd party repos, which sometimes have reliability issues.
# See https://cockroachlabs.atlassian.net/wiki/spaces/devinf/pages/3462594561/Docker+image+sync for the details.
FROM us-east1-docker.pkg.dev/crl-docker-sync/docker-mirror/docker.io/library/ubuntu:focal
FROM us-east1-docker.pkg.dev/crl-docker-sync/docker-io/library/ubuntu:focal
ARG TARGETPLATFORM

RUN apt-get update \
Expand Down
6 changes: 3 additions & 3 deletions build/bazelutil/distdir_files.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -327,15 +327,15 @@ DISTDIR_FILES = {
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/cmux/com_github_cockroachdb_cmux-v0.0.0-20170110192607-30d10be49292.zip": "88f6f9cf33eb535658540b46f6222f029398e590a3ff9cc873d7d561ac6debf0",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/cockroach-go/v2/com_github_cockroachdb_cockroach_go_v2-v2.3.7.zip": "028c29c79c2d373bca3ce9a475291285fdcb68a2f908190f738d5ce605edbd07",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/crlfmt/com_github_cockroachdb_crlfmt-v0.0.0-20221214225007-b2fc5c302548.zip": "fedc01bdd6d964da0425d5eaac8efadc951e78e13f102292cc0774197f09ab63",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/crlib/com_github_cockroachdb_crlib-v0.0.0-20240729155931-991150b7e290.zip": "75022b33828ba2c915827a3e217ea5d19bd1e7c6aa702b344cf3d349ae7f31b4",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/crlib/com_github_cockroachdb_crlib-v0.0.0-20240816115810-1c502cdb7c1d.zip": "ab49848ce4daea2599f91fd17942826bf62532b6d71af8bf8a02f4dff97118f3",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/datadriven/com_github_cockroachdb_datadriven-v1.0.3-0.20240530155848-7682d40af056.zip": "f4cb70fec2b2904a56bfbda6a6c8bf9ea1d568a5994ecdb825f770671119b63b",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/errors/com_github_cockroachdb_errors-v1.11.3.zip": "d11ed59d96afef2d1f0ce56892839c62ff5c0cbca8dff0aaefeaef7eb190e73c",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/fifo/com_github_cockroachdb_fifo-v0.0.0-20240606204812-0bbfbd93a7ce.zip": "41e682b393cc82891ab5fcefbd28cc6173f16887702ab8760bcbc66d122e5900",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/go-test-teamcity/com_github_cockroachdb_go_test_teamcity-v0.0.0-20191211140407-cff980ad0a55.zip": "bac30148e525b79d004da84d16453ddd2d5cd20528e9187f1d7dac708335674b",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/gostdlib/com_github_cockroachdb_gostdlib-v1.19.0.zip": "c4d516bcfe8c07b6fc09b8a9a07a95065b36c2855627cb3514e40c98f872b69e",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/logtags/com_github_cockroachdb_logtags-v0.0.0-20230118201751-21c54148d20b.zip": "ca7776f47e5fecb4c495490a679036bfc29d95bd7625290cfdb9abb0baf97476",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/metamorphic/com_github_cockroachdb_metamorphic-v0.0.0-20231108215700-4ba948b56895.zip": "28c8cf42192951b69378cf537be5a9a43f2aeb35542908cc4fe5f689505853ea",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20240801172554-a466dadd19f0.zip": "364fa399a7b5479feaf2af30cb833cb1aac153d5aec05df0d63f24c3b4d58299",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20240820151534-3d14906a0e0c.zip": "d599fcb2be858abbdf59fd73b09b214650b8b1d3883bf90d509a998849baa699",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/redact/com_github_cockroachdb_redact-v1.1.5.zip": "11b30528eb0dafc8bc1a5ba39d81277c257cbe6946a7564402f588357c164560",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/returncheck/com_github_cockroachdb_returncheck-v0.0.0-20200612231554-92cdbca611dd.zip": "ce92ba4352deec995b1f2eecf16eba7f5d51f5aa245a1c362dfe24c83d31f82b",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/stress/com_github_cockroachdb_stress-v0.0.0-20220803192808-1806698b1b7b.zip": "3fda531795c600daf25532a4f98be2a1335cd1e5e182c72789bca79f5f69fcc1",
Expand Down Expand Up @@ -702,7 +702,7 @@ DISTDIR_FILES = {
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kataras/tunnel/com_github_kataras_tunnel-v0.0.4.zip": "1ae8dcc9a6ca3f47c5f8b57767a08b0acd916eceef49c48aa9859547316db8e2",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kballard/go-shellquote/com_github_kballard_go_shellquote-v0.0.0-20180428030007-95032a82bc51.zip": "ae4cb7b097dc4eb0c248dff00ed3bbf0f36984c4162ad1d615266084e58bd6cc",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kevinburke/go-bindata/com_github_kevinburke_go_bindata-v3.13.0+incompatible.zip": "f087b3a77624a113883bac519ebd1a4de07b70ab2ebe73e61e52325ac30777e0",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kisielk/errcheck/com_github_kisielk_errcheck-v1.6.1-0.20210625163953-8ddee489636a.zip": "99d3220891162cb684f8e05d54f3d0dc58abdd496a2f0cfda7fd4a28917a719e",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kisielk/errcheck/com_github_kisielk_errcheck-v1.7.0.zip": "f394d1df1f2332387ce142d98734c5c44fb94e9a8a2af2a9b75aa4ec4a64b963",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/kisielk/gotool/com_github_kisielk_gotool-v1.0.0.zip": "089dbba6e3aa09944fdb40d72acc86694e8bdde01cfc0f40fe0248309eb80a3f",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/klauspost/asmfmt/com_github_klauspost_asmfmt-v1.3.2.zip": "fa6a350a8677a77e0dbf3664c6baf23aab5c0b60a64b8f3c00299da5d279021f",
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/klauspost/compress/com_github_klauspost_compress-v1.17.8.zip": "648bbc7813dec448eec1a5a467750696bc7e41e1ac0a00b76a967c589826afb6",
Expand Down
2 changes: 1 addition & 1 deletion build/deploy/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# We use a docker image mirror to avoid pulling from 3rd party repos, which sometimes have reliability issues.
# See https://cockroachlabs.atlassian.net/wiki/spaces/devinf/pages/3462594561/Docker+image+sync for the details.
FROM us-east1-docker.pkg.dev/crl-docker-sync/docker-mirror/registry.access.redhat.com/ubi9/ubi-minimal
FROM us-east1-docker.pkg.dev/crl-docker-sync/registry-access-redhat-com/ubi9/ubi-minimal
ARG fips_enabled

# For deployment, we need the following additionally installed:
Expand Down
Loading
Loading