Teamcity build

.bazelrc

@@ -26,18 +26,16 @@ build --flag_alias=cross=//build/toolchains:cross_flag
 build --flag_alias=dev=//build/toolchains:dev_flag
 build --flag_alias=force_build_cdeps=//build/toolchains:force_build_cdeps_flag
 build --flag_alias=heavy=//build/toolchains:heavy_flag
-build --flag_alias=lintonbuild=//build/toolchains:nogo_flag
-build --flag_alias=nolintonbuild=//build/toolchains:nonogo_explicit_flag
 
 build:crdb_test_off --crdb_test_off
 build:cross --cross
 build:dev --dev
 build:force_build_cdeps --force_build_cdeps
 build:heavy --heavy
-build:lintonbuild --lintonbuild
-build:nolintonbuild --nolintonbuild
+build:lintonbuild --run_validations
+build:nolintonbuild --norun_validations
 # Note: nonogo is classically the name of the nolintonbuild configuration.
-build:nonogo --nolintonbuild
+build:nonogo --config nolintonbuild
 build:test --crdb_test
 
 # Basic settings.
@@ -65,7 +63,7 @@ test:race --heavy
 # CI uses a custom timeout for enormous targets.
 test:use_ci_timeouts --test_timeout=60,300,900,900
 # CI should always run with `--config=ci`.
-build:cibase --lintonbuild
+build:cibase --config=lintonbuild
 # Set `-test.v` in Go tests.
 # Ref: https://github.com/bazelbuild/rules_go/pull/2456
 test:cibase --test_env=GO_TEST_WRAP_TESTV=1
@@ -91,7 +89,7 @@ build:crosslinuxfips '--workspace_status_command=./build/bazelutil/stamp.sh x86_
 build:crosslinuxfips --config=crosslinuxfipsbase
 build:crosslinuxfipsbase --platforms=//build/toolchains:cross_linux
 build:crosslinuxfipsbase --config=cross
-build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.22.5fips
+build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.22.8fips
 build:crosswindows '--workspace_status_command=./build/bazelutil/stamp.sh x86_64-w64-mingw32'
 build:crosswindows --config=crosswindowsbase
 build:crosswindowsbase --platforms=//build/toolchains:cross_windows

.github/CODEOWNERS

@@ -167,7 +167,7 @@
 /pkg/cli/syncbench/          @cockroachdb/storage @cockroachdb/kv-prs
 /pkg/cli/swappable_fs*       @cockroachdb/storage
 /pkg/cli/testutils.go        @cockroachdb/test-eng
-/pkg/cli/tsdump.go           @cockroachdb/obs-prs @cockroachdb/obs-india-prs
+/pkg/cli/tsdump*.go          @cockroachdb/obs-prs @cockroachdb/obs-india-prs
 /pkg/cli/userfile.go         @cockroachdb/disaster-recovery
 /pkg/cli/workload*           @cockroachdb/sql-foundations
 /pkg/cli/zip*.go             @cockroachdb/obs-prs    @cockroachdb/cli-prs @cockroachdb/obs-india-prs
@@ -181,6 +181,7 @@
 /pkg/server/admin*.go                    @cockroachdb/obs-prs @cockroachdb/server-prs
 /pkg/server/api_v2*.go                   @cockroachdb/obs-prs @cockroachdb/server-prs
 /pkg/server/api_v2_auth*.go              @cockroachdb/obs-prs @cockroachdb/server-prs @cockroachdb/prodsec @cockroachdb/product-security
+/pkg/server/application_api/             @cockroachdb/obs-prs
 /pkg/server/authentication*.go           @cockroachdb/prodsec     @cockroachdb/server-prs @cockroachdb/product-security
 /pkg/server/clock_monotonicity.go        @cockroachdb/kv-prs
 /pkg/server/combined_statement_stats*.go @cockroachdb/obs-prs
@@ -200,6 +201,7 @@
 /pkg/server/init*.go                     @cockroachdb/kv-prs      @cockroachdb/server-prs
 /pkg/server/intent_*.go                  @cockroachdb/kv-prs      @cockroachdb/server-prs
 /pkg/server/key_vis*                     @cockroachdb/obs-prs
+/pkg/server/license/                     @cockroachdb/sql-foundations
 /pkg/server/load_endpoint*               @cockroachdb/obs-prs @cockroachdb/server-prs
 /pkg/server/loss_of_quorum*.go           @cockroachdb/kv-prs
 /pkg/server/migration*                   @cockroachdb/sql-foundations
@@ -572,17 +574,17 @@
 /pkg/ts/catalog/             @cockroachdb/obs-prs
 #!/pkg/util/                 @cockroachdb/unowned
 /pkg/util/addr/              @cockroachdb/obs-prs
+/pkg/util/admission/         @cockroachdb/admission-control
+/pkg/util/goschedstats       @cockroachdb/admission-control
+/pkg/util/grunning/          @cockroachdb/admission-control
 /pkg/util/log/               @cockroachdb/obs-prs @cockroachdb/obs-india-prs
 /pkg/util/metric/            @cockroachdb/obs-prs @cockroachdb/obs-india-prs
-/pkg/util/tracing            @cockroachdb/obs-prs @cockroachdb/obs-india-prs
-/pkg/util/stop/              @cockroachdb/kv-prs
-/pkg/util/grunning/          @cockroachdb/admission-control
-/pkg/util/admission/         @cockroachdb/admission-control
-/pkg/util/schedulerlatency/  @cockroachdb/admission-control
 /pkg/util/mon                @cockroachdb/sql-queries-prs
+/pkg/util/schedulerlatency/  @cockroachdb/admission-control
+/pkg/util/stop/              @cockroachdb/kv-prs
+/pkg/util/tracing            @cockroachdb/obs-prs @cockroachdb/obs-india-prs
 /pkg/workload/               @cockroachdb/test-eng #! @cockroachdb/sql-foundations-noreview
 /pkg/obs/                    @cockroachdb/obs-prs
-/pkg/obsservice/             @cockroachdb/obs-prs
 /pkg/ccl/auditloggingccl     @cockroachdb/obs-prs
 /pkg/cmd/drt*                @cockroachdb/test-eng
 

.github/workflows/bincheck.yml

@@ -16,13 +16,13 @@ jobs:
     - run: cd build/release/bincheck && ./test-linux ${{ github.ref_name }} ${{ github.sha }}
 
   darwin-amd64:
-    runs-on: macos-latest
+    runs-on: macos-13
     steps:
     - uses: actions/checkout@v3
     - run: cd build/release/bincheck && ./test-macos-amd64 ${{ github.ref_name }} ${{ github.sha }}
 
   darwin-arm64:
-    runs-on: macos-latest-xlarge
+    runs-on: macos-latest
     steps:
     - uses: actions/checkout@v3
     - run: cd build/release/bincheck && ./test-macos-arm64 ${{ github.ref_name }} ${{ github.sha }}

.github/workflows/update_releases.yaml

@@ -31,6 +31,7 @@ jobs:
           - "release-23.2"
           - "release-24.1"
           - "release-24.2"
+          - "release-24.3"
     name: Update pkg/testutils/release/cockroach_releases.yaml on ${{ matrix.branch }}
     runs-on: ubuntu-latest
     steps:

.gitignore

@@ -28,8 +28,6 @@ work-Fuzz*
 /vendor
 # vendoring by `go mod vendor` may produce this file temporarily
 /.vendor.tmp.*
-# The Observability Service binary.
-/obsservice
 # The Workload Binary
 /workload
 # Instrumentation artifacts.

AUTHORS

@@ -460,6 +460,7 @@ Spencer Kimball <[email protected]> <[email protected]>
 Stan Rosenberg <[email protected]> <[email protected]>
 Stephanie Bodoff <[email protected]>
 Stephen Mooney <[email protected]> <[email protected]>
+Stephen Yang <[email protected]>
 Steven Danna <[email protected]>
 Steven Hand <@cockroachlabs.com> hand <@cockroachlabs.com> hand-crdb <@cockroachlabs.com>
 Steven Hubbard <[email protected]> <[email protected]>

BUILD.bazel

@@ -152,61 +152,58 @@ nogo(
     name = "crdb_nogo",
     config = "//build/bazelutil:nogo_config.json",
     visibility = ["//visibility:public"],
-    deps = select({
-        "//build/toolchains:nogo": [
-            "@org_golang_x_tools//go/analysis/passes/asmdecl:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/assign:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/atomic:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/atomicalign:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/bools:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/buildssa:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/buildtag:go_default_library",
-            # TODO(rules_go#2396): pass raw cgo sources to cgocall and re-enable.
-            # "@org_golang_x_tools//go/analysis/passes/cgocall:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/composite:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/copylock:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/ctrlflow:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/deepequalerrors:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/errorsas:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/findcall:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/httpresponse:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/ifaceassert:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/inspect:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/lostcancel:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/nilfunc:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/nilness:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/pkgfact:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/printf:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/shift:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/sortslice:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/stdmethods:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/stringintconv:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/structtag:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/testinggoroutine:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/tests:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/unmarshal:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/unreachable:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/unsafeptr:go_default_library",
-            "@org_golang_x_tools//go/analysis/passes/unusedresult:go_default_library",
-            "//pkg/testutils/lint/passes/deferunlockcheck",
-            "//pkg/testutils/lint/passes/descriptormarshal",
-            "//pkg/testutils/lint/passes/errcheck",
-            "//pkg/testutils/lint/passes/errcmp",
-            "//pkg/testutils/lint/passes/errwrap",
-            "//pkg/testutils/lint/passes/fmtsafe",
-            "//pkg/testutils/lint/passes/grpcclientconnclose",
-            "//pkg/testutils/lint/passes/grpcstatuswithdetails",
-            "//pkg/testutils/lint/passes/hash",
-            "//pkg/testutils/lint/passes/leaktestcall",
-            "//pkg/testutils/lint/passes/nilness",
-            "//pkg/testutils/lint/passes/nocopy",
-            "//pkg/testutils/lint/passes/redactcheck",
-            "//pkg/testutils/lint/passes/returncheck",
-            "//pkg/testutils/lint/passes/returnerrcheck",
-            "//pkg/testutils/lint/passes/shadow",
-            "//pkg/testutils/lint/passes/timer",
-            "//pkg/testutils/lint/passes/unconvert",
-        ] + STATICCHECK_CHECKS,
-        "//conditions:default": [],
-    }),
+    deps = [
+        "@org_golang_x_tools//go/analysis/passes/asmdecl:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/assign:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/atomic:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/atomicalign:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/bools:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/buildssa:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/buildtag:go_default_library",
+        # TODO(rules_go#2396): pass raw cgo sources to cgocall and re-enable.
+        # "@org_golang_x_tools//go/analysis/passes/cgocall:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/composite:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/copylock:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/ctrlflow:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/deepequalerrors:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/errorsas:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/findcall:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/httpresponse:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/ifaceassert:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/inspect:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/lostcancel:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/nilfunc:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/nilness:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/pkgfact:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/printf:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/shift:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/sortslice:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/stdmethods:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/stringintconv:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/structtag:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/testinggoroutine:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/tests:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/unmarshal:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/unreachable:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/unsafeptr:go_default_library",
+        "@org_golang_x_tools//go/analysis/passes/unusedresult:go_default_library",
+        "//pkg/testutils/lint/passes/deferunlockcheck",
+        "//pkg/testutils/lint/passes/descriptormarshal",
+        "//pkg/testutils/lint/passes/errcheck",
+        "//pkg/testutils/lint/passes/errcmp",
+        "//pkg/testutils/lint/passes/errwrap",
+        "//pkg/testutils/lint/passes/fmtsafe",
+        "//pkg/testutils/lint/passes/grpcclientconnclose",
+        "//pkg/testutils/lint/passes/grpcstatuswithdetails",
+        "//pkg/testutils/lint/passes/hash",
+        "//pkg/testutils/lint/passes/leaktestcall",
+        "//pkg/testutils/lint/passes/nilness",
+        "//pkg/testutils/lint/passes/nocopy",
+        "//pkg/testutils/lint/passes/redactcheck",
+        "//pkg/testutils/lint/passes/returncheck",
+        "//pkg/testutils/lint/passes/returnerrcheck",
+        "//pkg/testutils/lint/passes/shadow",
+        "//pkg/testutils/lint/passes/timer",
+        "//pkg/testutils/lint/passes/unconvert",
+    ],
 )