Drop v1 compatibility plugin #802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to my understanding, v1 of SCE relied upon jQuery. Could we then also drop jQuery (seems to be used heavily in the tests) |
|
The only file still using jQuery outside of tests is https://github.com/samclarke/SCEditor/blob/master/src/jquery.sceditor.js which is for backwards compatibility and doesn't have an effect on the rest of the code (it relies on there being a global jQuery variable). That could be deprecated and then dropped though. jQuery could be removed from the unit tests, would just require replacing the jQuery code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the compatibility plugin for version 1 as shouldn't be needed anymore.