Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Package for PDF export and made PDF templates accessible from outside the container #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FreakyBytes
Copy link

@FreakyBytes FreakyBytes commented Jul 26, 2018

Hi,

this PR fixes issues I encountered with the PDF exports due to the missing php-xml package.
Further it adds the capability to add and modify PDF/Web templates in a similar way as the upload folder is handled.

fixes #3

@sameersbn
Copy link
Owner

@FreakyBytes I am worried if this will cause any issues while upgrading between versions. I think we should rather allow users place their invoice and pdf templates at the templates/invoice and templates/pdf paths in the INVOICEPLANE_DATA_DIR location. The image should then sync the contents of these folders at the respective locations in INVOICEPLANE_INSTALL_DIR

@sameersbn
Copy link
Owner

fixes issues I encountered with the PDF exports due to the missing php-xml package

What issue do you notice as a result of this missing package? With the current release I am able to render PDF invoices. Not sure about the issue you are mentioning

@FreakyBytes
Copy link
Author

@sameersbn Not entirely sure, if I can follow you. The $INVOICEPLANE_DOCUMENT_TEMPLATES variable defaults to $INVOICEPLANE_DATA_DIR/templates, following the mechanism for the uploads directory.

Regarding the issues I experienced: I had some weird issues with the stock image (no modifications, other templates etc.) where I could generate quote pdfs, but got a server error for invoices. This could be fixed by manually installing php-xml in the container, based on clues from the InvoicePlane internal log files.
Unfortunately, did idiot-me not save the logs and I'm currently a bit too busy to recreate the issue. But if you want I can look into this again, after the weekend. :)

@noplanman
Copy link

Just voicing my interest in getting the templates customisable 👍
Hoping to see this merged soon.

@noplanman
Copy link

I too was having issues with the PDF rendering, error log stated that Class 'DOMDocument' not found, so after installing php7.2-xml it worked perfectly.

So this is absolutely necessary to have installed 👍

@noplanman
Copy link

@sameersbn Are you still maintaining this image? Does it work flawlessy for you as is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizing templates
3 participants