Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen sqlite3 dependency #217

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Loosen sqlite3 dependency #217

merged 1 commit into from
Jun 7, 2024

Conversation

trliner
Copy link
Contributor

@trliner trliner commented Jun 7, 2024

Description

Loosen the sqlite3 dependency to allow versions > 1.4.2 and < 2.0.

Motivation and Context

Restricting sqlite3 to the 1.4 series is causing installation issues for users on newer Ruby versions. There doesn't seem to be a technical reason for this restriction as timetrap still works with later 1.x sqlite3 versions.

How Has This Been Tested?

I've run timetrap's test suite with multiple sqlite3 versions, including 1.5.4, 1.6.9, and 1.7.3. Also, using the updated gemspec, I've been able to install timetrap in Ruby environments that it currently fails to install in.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@trliner trliner mentioned this pull request Jun 7, 2024
@dechimp dechimp merged commit 46e80f9 into samg:master Jun 7, 2024
1 check failed
@trliner trliner deleted the sqlite_upgrade branch August 16, 2024 19:23
@trliner
Copy link
Contributor Author

trliner commented Aug 16, 2024

@dechimp Would you mind releasing a new version with this change included please?

@dechimp
Copy link
Collaborator

dechimp commented Aug 16, 2024

Sure. 1.15.2

@benj-dobs
Copy link

Can I just check that this release worked? On rubygems.org, v1.15.2 is from 2020: https://rubygems.org/gems/timetrap

@dechimp
Copy link
Collaborator

dechimp commented Aug 20, 2024

Interesting. The highest tag version was 1.15.1 when I created the release, so I bumped it to 1.15.2. The release hash is 2edfac2 which is the same as the latest master (with this fix merged in). I cant imagine it not working. If you need me to bump it again, LMK.

@dechimp
Copy link
Collaborator

dechimp commented Aug 20, 2024

Sorry, it actually looks like we might need to create a github action or something that creates a new release on rubygems.org. I'm new to this so I'll have to figure that out and get things going. I'm a newly-appointed collaborator so I don't have control over the gem on RubyGems. @samg can you help out on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants