Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rspec GitHub Action to properly execute #218

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

trliner
Copy link
Contributor

@trliner trliner commented Jun 10, 2024

Description

Update .github/workflows/rspec.yml so that the rspec GitHub action executes properly, and pull requests can be merged with greater confidence.

Motivation and Context

The rspec action is failing in the master branch with an error message instructing to migrate to ruby/setup-ruby. That version of setup-ruby automatically installs a bundler version compatible with the specified Ruby version, so it's no longer necessary to install bundler directly. Also, rspec is included as a development dependency within the gemspec, so it's not necessary to install that directly either.

How Has This Been Tested?

The rspec action now runs successfully: https://github.com/samg/timetrap/pull/218/checks

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dechimp
Copy link
Collaborator

dechimp commented Jun 10, 2024

Thank you for doing this!

@dechimp dechimp closed this Jun 10, 2024
@dechimp dechimp reopened this Jun 10, 2024
@dechimp dechimp merged commit 2edfac2 into samg:master Jun 10, 2024
2 checks passed
@trliner trliner deleted the fix_rspec_action branch June 12, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants