Extracts Saml::XML into SamlIdp::XML to free up the use of the Saml namespace #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your feedback and nice improvement. |
|
@pelted I have fixed the flaky test can you update your branches with the latest master branch? |
Zogoo
approved these changes
Nov 1, 2024
|
@pelted can you update your branch with the latest master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Samlnamespace and intoSamlIdp1Saml::XMLtoSamlIdp::XMLWhy
Defining such a generic namespace as
Samlin this gem causes namespace collisions for projects attempting to use saml-idp which may define their ownSamlmodule. We shouldn't do that here. There was even a note to that affect in the form of a long standingTODOitem to extract this.Footnotes
This is opinionated to avoid the repetition of
SamlIdp::Saml::Xml↩