Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support patterns containing spaces #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elzibubble
Copy link

There's special support for "$@". If $@ => "a b c", then "$@" => "a" "b" "c".

@elzibubble
Copy link
Author

Fixes issue #21

@sampson-chen
Copy link
Owner

Apologies for neglecting pull requests for so long. I just merged several, and this one now has conflicts. Please update if you are interested in having it in, or I'll take a look at it hopefully sometime next week.

@Konfekt
Copy link

Konfekt commented Jan 19, 2016

Hey, how to see these merge conflicts and resolve them? Would be great if sack could search for patterns with spaces.

@Konfekt
Copy link

Konfekt commented Jan 19, 2016

After all, the pull request does not look to complicated. Should I reoffer it?

@Konfekt Konfekt mentioned this pull request Jan 19, 2016
@elzibubble
Copy link
Author

Hi Konfekt, please feel free. I spent all of 20 seconds on it mind, it may
not be super robust.

On Tue, 19 Jan 2016 at 11:42 Konfekt [email protected] wrote:

After all, the pull request does not look to complicated. Should I reoffer
it?


Reply to this email directly or view it on GitHub
#22 (comment).

@Konfekt
Copy link

Konfekt commented Jan 20, 2016

Yeah, actually there's now #31 but it doesn't fix much. For the moment switched to https://raw.githubusercontent.com/majutsushi/etc/master/zsh/sack

1 similar comment
@Konfekt
Copy link

Konfekt commented Jan 20, 2016

Yeah, actually there's now #31 but it doesn't fix much. For the moment switched to https://raw.githubusercontent.com/majutsushi/etc/master/zsh/sack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants