update vim shortcut command to work when shortcuts file has no line n… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umbers When running via -l to just list files that match without line numbers, the "F *" commands didn't work properly. Update the shortcut command to check to see if line numbers are present. If so, open starting at that file. If not, just open the file.
"equals 2" fails if the filenames have spaces in them. change to "greaterthan/equal to 2"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often use grep/ack/ag with the "-l" switch to just list relevant files without listing exact line number matches. sack/sag displays good output with this switch, but the generated ~/.sack_shortcuts file causes problems in the create_shortcut_vim_cmd function. This change updates that function to check to see if line numbers are present in ~/.sack_shortcuts. If they are, it functions as before. If not, it launches Vim without a line number.
I didn't test this functionality with other editors, this just affects Vim users.