Use strict Base64 encoding to prevent bad requests #12

stewartpark · 2021-01-11T22:19:11Z

With Array#pack, if the credentials is too long, it ends up adding a
new line in the middle of the resulting base64 encoded string, which results in
a 400 Bad Request. To fix this, Base64.strict_encode64 should be used.

Bad:

CONNECT blah:80 HTTP/1.1
Proxy-Authorization: Basic YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhOmJiYmJiYmJiYmJiYmJi
YmJiYmJi
...

Good:

CONNECT blah:80 HTTP/1.1
Proxy-Authorization: Basic YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhOmJiYmJiYmJiYmJiYmJiYmJiYmJi
...

With `Array#pack`, if the credentials is too long, it ends up adding a new line in the middle of the base64 encoded string, which results in a 400 Bad Request. To fix this, `Base64.strict_encode64` is now used.

Use strict Base64 encoding to prevent bad requests

51b7aa7

With `Array#pack`, if the credentials is too long, it ends up adding a new line in the middle of the base64 encoded string, which results in a 400 Bad Request. To fix this, `Base64.strict_encode64` is now used.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use strict Base64 encoding to prevent bad requests #12

Use strict Base64 encoding to prevent bad requests #12

stewartpark commented Jan 11, 2021

Use strict Base64 encoding to prevent bad requests #12

Are you sure you want to change the base?

Use strict Base64 encoding to prevent bad requests #12

Conversation

stewartpark commented Jan 11, 2021