Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing demo API key [BREAKING CHANGE] #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bahaa-kallas
Copy link

Enable passing demo API key to the client. This change is a breaking change but as the library is pre 1.0.0 stage I will leave the versioning up to the library author to decide how to proceed.

@bahaa-kallas
Copy link
Author

@samuraitruong would really appreciate a review of these changes. I will happily apply any requested changes.

Best regards

Copy link

@ErcouldnT ErcouldnT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants