This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
Makes terms_for_display accesible on Worthwhile::GenericFile #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ module GenericFileBase | |||
| include Sufia::GenericFile::Derivatives | |||
| include Sufia::GenericFile::Metadata | |||
| include Sufia::GenericFile::Versions | |||
| include Sufia::Permissions::Readable | |||
| include Sufia::GenericFile::Permissions | |||
There was a problem hiding this comment.
I don't think we want Sufia::GenericFile::Permissions because that introduces methods that overwrite Hydra::AccessControls::Permissions
flyingzumwalt
force-pushed
the
generic_file_title_accesible
branch
from
c95ceef to
946e4d4
Compare
| @@ -5,6 +5,11 @@ | |||
| subject.depositor = '[email protected]' | |||
| end | |||
|
|
|||
| it "should update attributes" do | |||
| subject.attributes = {title:"My new Title"} | |||
There was a problem hiding this comment.
This causes a deprecation warning:
.DEPRECATION WARNING: You attempted to set the attribute `title' on `Worthwhile::GenericFile' to a scalar value. However, this attribute is declared as being multivalued. This behavior is deprecated and will raise an ArgumentError in active-fedora 8.0.0. (called from block in attributes= at /home/travis/.rvm/gems/ruby-2.1.4/gems/active-fedora-7.1.1/lib/active_fedora/attributes.rb:21)
Can you set it to an array instead?
| @@ -132,10 +132,11 @@ | |||
| end | |||
|
|
|||
| context "updating metadata" do | |||
| it "should be successful" do | |||
| it "should be successful and update attributes" do | |||
| post :update, id: generic_file, generic_file: | |||
| {title: 'new_title', tag: [''], permissions: { new_user_name: {'archivist1'=>'edit'}}} | |||
There was a problem hiding this comment.
Would you mind setting the title value to an array? I think it causes a deprecation warning, although I know you didn't cause it.
flyingzumwalt
force-pushed
the
generic_file_title_accesible
branch
2 times, most recently
from
3aeb2a3 to
88dd5a0
Compare
…ield on GenericFile create/update form actually gets applied to the GenericFile object refs #34
flyingzumwalt
force-pushed
the
generic_file_title_accesible
branch
from
88dd5a0 to
7fd39d1
Compare
|
@jcoyne it looks like this is ready to be merged. Does it need any other attention? |
jcoyne
added a commit
that referenced
this pull request
Nov 12, 2014
Makes terms_for_display accesible on Worthwhile::GenericFile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that the :title attribute (along with any other terms) on GenericFile create/update form actually gets applied to the GenericFile object
refs #34