Bulkrax should show errors when remote urls are not valid #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bulrax jobs were continuing without reporting an error, with nothing appearing in the logs due to how the workers & logs interact. This commit causes file errors to be reported in the importer even though the job will end normally.
Got the message `Gem::LoadError: pg is not part of the bundle. Add it to your Gemfile. (Gem::LoadError)` so this commit will add pg to the Gemfile.
ShanaLMoore
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bulkrax jobs were continuing without reporting an error, with nothing appearing in the logs.
This commit causes file errors to be reported in the importer even though the job will end normally.
Screenshots