Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning blacklight_gallery to 4.7.x due to JS locations altered in 4.8.x #6987

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

randalldfloyd
Copy link
Contributor

The current gem spec for blacklight_gallery allows it to upgrade to 4.8.1, which has rearranged Javascript packaging through a series of commits in the last couple of weeks. The result in Hyrax is:

Sprockets::FileNotFound: couldn't find file 'blacklight_gallery/default'

This PR would fix the problem by pinning the gem to 4.7.x.

@samvera/hyrax-code-reviewers

Copy link

github-actions bot commented Jan 14, 2025

Test Results

    13 files  ±    0      13 suites  +4   3h 3m 56s ⏱️ + 2h 12m 4s
 6 833 tests +1 918   6 534 ✅ +1 693  299 💤 +228  0 ❌  - 3 
18 100 runs  +6 669  17 623 ✅ +6 337  477 💤 +335  0 ❌  - 3 

Results for commit f92dc43. ± Comparison against base commit b6dcb8a.

This pull request removes 196 and adds 2114 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7cf701b190>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc3ecaf3220>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7cf581e600>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc3edbd67e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b80ab796-cc18-4f46-b941-a2423f3492b5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: cf2f9118-779c-46d3-b30d-07a75e76769a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 739c7cb3-b66c-442f-a85f-50a2675fd88e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: f5c7f117-8629-42f1-94d4-355c5785c74e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 2c3d659a-0c10-44ff-8e4c-951af77b8c56
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 63e6e822-9c3d-4487-85bc-7e394d9b7706
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f646668af20>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f86a7661900>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd8e3181f50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f646626c808>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f86a76c6f58>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd8e21d3720>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 35e38d98-7543-48ac-a5dc-b268f5a53f63
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4000397f-00fe-4982-8ca4-d3a1eb4ae6f5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 78d4246e-700f-4dc0-a85f-51ee26d563ab
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 35ca06a0-4668-4ced-840e-c9fb2e17181f
…

♻️ This comment has been updated with latest results.

@randalldfloyd randalldfloyd marked this pull request as ready for review January 14, 2025 17:21
@randalldfloyd randalldfloyd changed the title DRAFT: Pinning blacklight_gallery to 4.7.x due to JS locations altered in 4.8.x Pinning blacklight_gallery to 4.7.x due to JS locations altered in 4.8.x Jan 14, 2025
@dlpierce dlpierce merged commit 3788d40 into main Jan 15, 2025
17 checks passed
@dlpierce dlpierce deleted the fix-blacklight_gallery-compat branch January 15, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants