Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface to quantum resource estimation (QRE) tools #406

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

alexfleury-sb
Copy link
Collaborator

@alexfleury-sb alexfleury-sb commented Aug 6, 2024

Interface to other software quantum resource estimation (QRE) tools.

As of now, it supports:

There is no test at the moment for PyLIQTR because it is only working with a specific cirq version (cirq-core==1.3.0.dev20231018023458), and it is breaking the tangelo.linq module.

@alexfleury-sb alexfleury-sb marked this pull request as draft August 6, 2024 18:29
Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not convinced about the class design here, I do not really see what it brings to the table.

tangelo/toolboxes/circuits/qre.py Outdated Show resolved Hide resolved
tangelo/toolboxes/circuits/qre.py Outdated Show resolved Hide resolved
tangelo/toolboxes/circuits/qre.py Outdated Show resolved Hide resolved
@alexfleury-sb alexfleury-sb marked this pull request as ready for review August 7, 2024 15:33
Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry It took so long: minor docstring changes and we're good

tangelo/toolboxes/circuits/qre.py Show resolved Hide resolved
tangelo/toolboxes/circuits/qre.py Show resolved Hide resolved
Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@ValentinS4t1qbit ValentinS4t1qbit merged commit 9be3269 into sandbox-quantum:develop Sep 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants