Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out Notifications #217

Closed
wants to merge 1 commit into from
Closed

Comment out Notifications #217

wants to merge 1 commit into from

Conversation

sebwittr
Copy link
Contributor

In order to handle notifications costs we're pausing them for the summer. This change just comments out the line in the updater that handles notifications. The notification tests are also commented out.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 77.32% (-3.2%) from 80.481%
when pulling d70946e on sw/pause-notifs
into 33e48e4 on master.

Copy link
Member

@Lucas-Dunker Lucas-Dunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change to yarn.lock intentional? otherwise lgtm

@mehallhm
Copy link
Contributor

Given notifications are coming back online soon™️ this feels safe to close

@mehallhm mehallhm closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants