Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section filters #234

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Add section filters #234

merged 1 commit into from
Nov 10, 2024

Conversation

Anzhuo-W
Copy link
Contributor

Purpose

In returned results, only show specific sections that match all filters of the classes with at least one section that matches filters.

Before:
Screen Shot 2024-10-27 at 2 59 24 PM

After:
Screen Shot 2024-10-27 at 3 00 23 PM

Tickets

Addresses #233

Contributors

@Anzhuo-W

Feature List

When campus filters are applied, sections are only displayed for that campus instead of all sections for a course where at least one section is on that campus. The sections are filtered out from the results after they are returned by query; additionally applies to honors sections, class type, and subject.

Reviewers

Primary reviewer:
@ananyaspatil

Secondary reviewers:
@nickpfeiffer05 @cherman23 @mehallhm

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.173% (-0.4%) from 80.533%
when pulling c8c5ada on filter-out-sections
into 6cd914e on master.

Copy link
Contributor

@mehallhm mehallhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there wasn't a way to iterate over everything multiple times, but I have no ideas rn. Depending on merge order, this might lightly conflict with Nick's #235

@mehallhm mehallhm linked an issue Oct 28, 2024 that may be closed by this pull request
@Anzhuo-W Anzhuo-W merged commit 561f7ea into master Nov 10, 2024
9 of 10 checks passed
@Anzhuo-W Anzhuo-W deleted the filter-out-sections branch November 10, 2024 19:01
ananyaspatil added a commit that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Campus Section Filter
3 participants