User transfer courses when generating pre-req errors (#613) (#628)

* Use transfer courses in getting req errors (#613) * Transfer courses add to only pre-req errors (#613)
sandboxnu · Oct 19, 2023 · e377149 · e377149
1 parent f584773
commit e377149
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/packages/frontend-v2/pages/home.tsx b/packages/frontend-v2/pages/home.tsx
@@ -101,7 +101,7 @@ const HomePage: NextPage = () => {
     if (student) {
       const plan = student.plans.find((plan) => plan.id === selectedPlanId);
       if (plan) {
-        setPreReqWarnings(getPreReqWarnings(plan.schedule));
+        setPreReqWarnings(getPreReqWarnings(plan.schedule, student.coursesTransfered));
         setCoReqWarnings(getCoReqWarnings(plan.schedule));
       }
     }
@@ -170,7 +170,7 @@ const HomePage: NextPage = () => {
       return;
     }
 
-    setPreReqWarnings(getPreReqWarnings(updatedPlan.schedule));
+    setPreReqWarnings(getPreReqWarnings(updatedPlan.schedule, student.coursesTransfered));
     setCoReqWarnings(getCoReqWarnings(updatedPlan.schedule));
     mutateStudentWithUpdatedPlan(updatedPlan);
   };

diff --git a/packages/frontend-v2/utils/plan/preAndCoReqCheck.ts b/packages/frontend-v2/utils/plan/preAndCoReqCheck.ts
@@ -8,12 +8,13 @@ import {
   INEUReqError,
   PreReqWarnings,
   Schedule2,
+  ScheduleCourse2,
   ScheduleTerm2,
   TermError,
 } from "@graduate/common";
 
 export const getCoReqWarnings = (
-  schedule: Schedule2<unknown>
+  schedule: Schedule2<unknown>,
 ): CoReqWarnings => {
   const errors: CoReqWarnings = {
     type: "coreq",
@@ -29,7 +30,7 @@ export const getCoReqWarnings = (
 };
 
 export const getCoReqWarningsSem = (
-  term: ScheduleTerm2<unknown>
+  term: ScheduleTerm2<unknown>,
 ): TermError => {
   const seen: Set<string> = new Set();
   const coReqErrors: TermError = {};
@@ -44,9 +45,15 @@ export const getCoReqWarningsSem = (
 };
 
 export const getPreReqWarnings = (
-  schedule: Schedule2<unknown>
+  schedule: Schedule2<unknown>,
+  coursesTransfered: ScheduleCourse2<null>[] | undefined
 ): PreReqWarnings => {
   const seen: Set<string> = new Set();
+  if (coursesTransfered != undefined) {
+    for (const course of coursesTransfered) {
+      seen.add(courseToString(course));
+    }
+  }
   const preReqErrors: PreReqWarnings = {
     type: "prereq",
     years: schedule.years.map((year) => ({