fixed linting errors

sandboxnu · Jan 21, 2024 · fa72de4 · fa72de4
1 parent 69b7060
commit fa72de4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 18 deletions.
diff --git a/packages/frontend/components/Plan/DeleteYearModal.tsx b/packages/frontend/components/Plan/DeleteYearModal.tsx
@@ -12,16 +12,14 @@ import {
   ModalOverlay,
   useDisclosure,
 } from "@chakra-ui/react";
-import { API } from "@graduate/api-client";
 import { useRouter } from "next/router";
-import { Dispatch, SetStateAction, useContext } from "react";
+import { Dispatch, SetStateAction } from "react";
 import { mutate } from "swr";
 import {
   USE_STUDENT_WITH_PLANS_SWR_KEY,
   useStudentWithPlans,
 } from "../../hooks";
 import { handleApiClientError, toast } from "../../utils";
-import { IsGuestContext } from "../../pages/_app";
 import { GraduateToolTip } from "../GraduateTooltip";
 
 interface DeleteYearModalProps {
@@ -34,7 +32,6 @@ export const DeleteYearModal: React.FC<DeleteYearModalProps> = ({
 }) => {
   const router = useRouter();
   const { onOpen, onClose, isOpen } = useDisclosure();
-  const { isGuest } = useContext(IsGuestContext);
   const { student } = useStudentWithPlans();
 
   if (!student) {

diff --git a/packages/frontend/hooks/useRedirectIfLoggedIn.ts b/packages/frontend/hooks/useRedirectIfLoggedIn.ts
@@ -15,22 +15,21 @@ export const useRedirectIfLoggedIn = () => {
   const [renderSpinner, setRenderSpinner] = useState(false);
   const { setIsGuest } = useContext(IsGuestContext);
 
-  const loginWithCookie = async () => {
-    setRenderSpinner(true);
-    try {
-      await API.student.getMe();
-      setIsGuest(false);
-      router.push("/home");
-    } catch (err) {
-      const error = err as AxiosError;
-      logger.error(error);
-      setRenderSpinner(false);
-    }
-  };
-
   useEffect(() => {
+    const loginWithCookie = async () => {
+      setRenderSpinner(true);
+      try {
+        await API.student.getMe();
+        setIsGuest(false);
+        router.push("/home");
+      } catch (err) {
+        const error = err as AxiosError;
+        logger.error(error);
+        setRenderSpinner(false);
+      }
+    };
     loginWithCookie();
-  }, []);
+  }, [setIsGuest]);
 
   return renderSpinner;
 };