Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Scraper Code out of Repo #647

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Move Scraper Code out of Repo #647

merged 1 commit into from
Nov 5, 2023

Conversation

AlpacaFur
Copy link
Member

Description

Moves scraper code out of this repo because it now lives in sandboxnu/major-scraper. This is very unlikely to break anything because none of our existing code relied on the scraper directly.

Type of change

  • Clean up/Refactor

How Has This Been Tested?

I built and ran both prod images to confirm that the code runs as usual.

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (not applicable)
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Nov 4, 2023 1:59pm

@AlpacaFur AlpacaFur linked an issue Nov 4, 2023 that may be closed by this pull request
3 tasks
@AlpacaFur AlpacaFur merged commit 8b3876b into main Nov 5, 2023
5 checks passed
@AlpacaFur AlpacaFur deleted the luke/remove-scraper-code branch November 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Scraper Code from sandboxnu/graduatenu
2 participants