Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NUPath #656

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Add support for NUPath #656

merged 6 commits into from
Nov 19, 2023

Conversation

daisykucharski
Copy link
Contributor

@daisykucharski daisykucharski commented Nov 12, 2023

Description

Added NUPath to ScheduleCourse type and calls to SearchNEU API

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Checked API call to make sure that NUPath was being populated

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Nov 19, 2023 8:50pm

@daisykucharski daisykucharski marked this pull request as draft November 19, 2023 20:31
@daisykucharski daisykucharski marked this pull request as ready for review November 19, 2023 20:49
Copy link
Contributor

@dkd2101 dkd2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and everything makes sense to me

@daisykucharski daisykucharski merged commit 74a0340 into main Nov 19, 2023
5 checks passed
@daisykucharski daisykucharski deleted the daisyk/nu-path branch November 19, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants