Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump next from 12.3.1 to 13.5.0 (#642)" #671

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

AlpacaFur
Copy link
Member

@AlpacaFur AlpacaFur commented Nov 23, 2023

This reverts commit e06a0e2.

Hotfix to fix a spiraling staging build.

Details pasted from Slack:

It seems like the combination of the next and axios updates broke the prod frontend docker container (can repro if you checkout commit e06a0e2) and build + run the frontend container.

Since the build errored on startup (Error: Cannot find module '/app/server.js'), ECS has been trying to restart it continuously for a few days, which will probably add a bit billing-wise (edit: doesn't seem to have made a billing difference, AWS might just not charge for startup time?).

Staging has been up since then only because ECS keeps the old ECR revision running until the new one starts successfully. Therefore, it's been running on an old revision/commit.

I've temporarily fixed the issue by manually redeploying an old commit hash to ECS but this PR should be merged so the issue doesn't resurface the next time someone merges into main (as commits to main cause an automatic staging redeploy)

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Nov 23, 2023 5:58am

Copy link
Contributor

@rael346 rael346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although probably have the stuff you wrote in Slack also in the PR's description for book-keeping

@AlpacaFur AlpacaFur merged commit 06f07ac into main Nov 23, 2023
@AlpacaFur AlpacaFur deleted the revert-next-update branch November 23, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants