Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for checkmarked courses in sidebar #672

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

yijen-sun
Copy link
Contributor

@yijen-sun yijen-sun commented Nov 23, 2023

Description

Adds support for a checkmark to appear in a course when it's in the sidebar, if the course has been added to the plan. Added attributes "isInSidebar" and "isChecked" in DraggableScheduleCourse component in order to enable this.

Validation is not implemented yet! This only adds support for when validation is good to go :)

Screenshot 2023-11-19 at 5 48 02 PM

Closes #652

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

  • Manually tested

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Nov 23, 2023 8:17pm

Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow so pretty

@yijen-sun yijen-sun merged commit 8306ea4 into main Dec 1, 2023
@yijen-sun yijen-sun deleted the sidebar-checkmark-support branch December 1, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show completed courses in the sidebar
2 participants