Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Landing Page #679

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Mobile Landing Page #679

merged 10 commits into from
Dec 1, 2023

Conversation

AngelaZQ1
Copy link
Contributor

Description

  • Made it so that we show a landing page on mobile according to this Figma design.
  • Added a base breakpoint to utils/theme/index.ts to target screens less than the tablet size.
  • Removed the weird space on the left in the husky svg
  • Fixed some responsiveness issues with very wide screens.
  • Added a footer to the landing page
Screen.Recording.2023-11-30.at.7.26.58.PM.mov

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Dec 1, 2023 0:45am

Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very pretty

@AngelaZQ1 AngelaZQ1 merged commit 210e48b into main Dec 1, 2023
5 checks passed
@AngelaZQ1 AngelaZQ1 deleted the mobile-landing-page branch December 1, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants