Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with adding a transfer course without a fullname #681

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

BrandonLim8890
Copy link
Contributor

Description

Previously, we would check if the user has a fullname when updating. When we made the change to allow users to not have a fullname, it would error in our backend. This PR just removes that check.
This means that previously, a user with an empty fullname could not add a new transfer course.

Closes #680

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Users without fullname can now add transfer courses.

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

@BrandonLim8890 BrandonLim8890 self-assigned this Dec 3, 2023
Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Dec 3, 2023 9:43pm

Copy link
Contributor

@DylanCerenov DylanCerenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BrandonLim8890 BrandonLim8890 merged commit d27e6fa into main Dec 3, 2023
5 checks passed
@BrandonLim8890 BrandonLim8890 deleted the brandon/fix-transfer-course-error branch December 3, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add transfer course as a user with an empty name
2 participants