Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder names to remove "v2" #687

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

BrandonLim8890
Copy link
Contributor

Description

Just went through README's and package json's to match the folder change. Also biggest pr in project history lmao.

IMPORTANT:
Now we can use yarn dev instead of yarn dev:v2. This has also been updated in the README.

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Just ran yarn dev to make sure things were running correctly. Then I ran the docker images to make sure that they built correctly.

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

@BrandonLim8890 BrandonLim8890 self-assigned this Jan 10, 2024
Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Jan 10, 2024 10:04pm

Copy link
Member

@AlpacaFur AlpacaFur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely also the biggest PR I've ever gotten to review! Code changes look good assuming it all typechecks and containers build successfully 👍

@BrandonLim8890 BrandonLim8890 merged commit bdbc557 into main Jan 14, 2024
5 of 6 checks passed
@BrandonLim8890 BrandonLim8890 deleted the brandon/folder-update branch January 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants