Select use placeholder #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AngelaZQ1
commented
Feb 7, 2024
| }), | ||
| dropdownIndicator: (baseStyles: any, state: { isFocused: any }) => ({ | ||
| ...baseStyles, | ||
| color: state.isFocused ? "#7586a0" : "#b4bbc8", |
There was a problem hiding this comment.
Our custom styles dont seem to work with react-select's styling so I had to hard code these colors
17 tasks
|
@BrandonLim8890 im gonna implement disabling the button until all fields are filled out in #704 since I think it makes more sense there |
| }), | ||
| dropdownIndicator: (baseStyles: any, state: { isFocused: any }) => ({ | ||
| ...baseStyles, | ||
| color: state.isFocused ? "#7586a0" : "#b4bbc8", |
There was a problem hiding this comment.
Suggested change
| color: state.isFocused ? "#7586a0" : "#b4bbc8", | |
| color: state.isFocused ? `${neutral.main.300}` : "#b4bbc8", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #696
Use react-select's placeholder attribute which lets you set placeholder text that is gray instead of black. Replaced noValueOptionLabel with placeholder which also removes the default value option from the list.
Other minor changes:
Before:
Screen.Recording.2024-02-07.at.5.11.30.PM.mov
After:
Screen.Recording.2024-02-07.at.5.12.18.PM.mov
Type of change
Please tick the boxes that best match your changes.
yarn installyarn dev:migration:runHow Has This Been Tested?
Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.
Checklist: