Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angela/add course modal UI tweaks #717

Merged
merged 7 commits into from
Mar 24, 2024

Conversation

AngelaZQ1
Copy link
Contributor

Description

Tweaked size, color, spacing of stuff in the Add Course modal. Also created a SecondaryButton component.

I also realized from these screenshots that NUpath selections are saved when closing and reopening the modal but is not visually represented as so. We should just clear the selections when the user closes the modal. Created a new issue for that here.

Before:
Screenshot 2024-03-01 at 3 22 36 PM

After:
Screenshot 2024-03-01 at 3 17 06 PM

Closes #715

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Mar 1, 2024 8:36pm

@AngelaZQ1 AngelaZQ1 requested review from BrandonLim8890, Suraj-Ram and dkd2101 and removed request for dkd2101 March 1, 2024 20:36
Copy link
Contributor

@BrandonLim8890 BrandonLim8890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!! 💯 🚢

@BrandonLim8890 BrandonLim8890 merged commit d692798 into main Mar 24, 2024
6 of 7 checks passed
@BrandonLim8890 BrandonLim8890 deleted the angela/add-course-modal-ui-tweaks branch March 24, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Course Modal Small UI Tweaks
2 participants