Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining warnings #733

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Add remaining warnings #733

merged 4 commits into from
Apr 11, 2024

Conversation

BrandonLim8890
Copy link
Contributor

@BrandonLim8890 BrandonLim8890 commented Apr 5, 2024

Description

Adds the following warnings:

  1. A warning over the sidebar stating again that its not fully accurate, even for majors that we have checked -- Here
  2. Warning over certain requirements within a major that we have hand-validated -- Here
  3. Pre req/co req warning -- Here
Screen.Recording.2024-04-05.at.16.56.49.mov

Closes #661

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Test on localhost

  • Test A
  • Test B

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Apr 10, 2024 9:45pm

@BrandonLim8890 BrandonLim8890 requested review from KobeZ123, AngelaZQ1 and Suraj-Ram and removed request for KobeZ123 April 5, 2024 21:02
</Flex>
{subtitle && (
<Text fontSize="sm" color="primary.blue.dark.main">
{subtitle}
</Text>
)}
</Box>
<Accordion pb="sm" allowToggle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good to me, but I think you can refactor this to another component. I know its not used else where, but it seems like Sidebar.tsx mainly contains built components and not Chakra primitives.

Copy link
Contributor

@AngelaZQ1 AngelaZQ1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only glanced through the code but visually everything looks good. I just added a period to the beta major tooltip.

@BrandonLim8890 BrandonLim8890 merged commit b1d9cdb into main Apr 11, 2024
6 of 7 checks passed
@BrandonLim8890 BrandonLim8890 deleted the blim/warnings branch April 11, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More prominent warning over degree audit
3 participants