-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining warnings #733
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
</Flex> | ||
{subtitle && ( | ||
<Text fontSize="sm" color="primary.blue.dark.main"> | ||
{subtitle} | ||
</Text> | ||
)} | ||
</Box> | ||
<Accordion pb="sm" allowToggle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely looks good to me, but I think you can refactor this to another component. I know its not used else where, but it seems like Sidebar.tsx mainly contains built components and not Chakra primitives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only glanced through the code but visually everything looks good. I just added a period to the beta major tooltip.
Description
Adds the following warnings:
Screen.Recording.2024-04-05.at.16.56.49.mov
Closes #661
Type of change
Please tick the boxes that best match your changes.
yarn install
yarn dev:migration:run
How Has This Been Tested?
Test on localhost
Checklist: