Beta Majors! #739
Merged
Beta Majors! #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrandonLim8890
approved these changes
Apr 15, 2024
| } | ||
|
|
||
| // TODO: this code is quick and dirty but works. this should be replaced with some dry-er code later. | ||
| async function collateMajors() { |
There was a problem hiding this comment.
My brain is slow but from what it looks like, we run through each year, each college and add all the majors. initial.json is our initial scrape and commit.json is the hand validated stuff?
If this is the case I can update this with comments/put it in our notion somewhere for knowledge transfer.
There was a problem hiding this comment.
Good call! Added some comments to the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a few beta majors to graduate + adapts the major loading infrastructure to dynamically load majors based on presence in the relevant folders.
Type of change
How Has This Been Tested?
Manual tests to ensure majors are being piped through properly.
Checklist: