Transfer credits now add up to total credits on sidebar #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KobeZ123
requested changes
Sep 15, 2024
| @@ -14,6 +14,8 @@ GraduateNU aims to empower Northeastern students to customize their plan of stud | |||
|
|
|||
| 5. Then run the new version of the application by running `yarn dev` at the root of the project. This starts up a NestJS server + a NextJS frontend + a Proxy. The proxy listens on port [3002](http://localhost:3002/), forwards /api requests to the NestJS server running on port 3001, and all other requests to the frontend running on port 3000. | |||
|
|
|||
| 5a. For Windows machines, run `yarn concurrently "yarn workspaces foreach --parallel --verbose --interlaced run dev" "yarn dev:proxy"` instead of `yarn dev` | |||
| }) => { | ||
| const creditsTaken = totalCreditsInSchedule(selectedPlan.schedule); | ||
| const transferCredits = transferCourses.reduce( |
There was a problem hiding this comment.
does the regular sidebar (the one that is not "no major") already support adding transfer course credits? if not, we should abstract the logic and add to both locations.
There was a problem hiding this comment.
Yes, I believe lines 193 - 199 add to the creditsTaken variable for the normal sidebar.
KobeZ123
requested changes
Sep 22, 2024
| (sum, course) => course.numCreditsMin + sum, | ||
| 0 | ||
| ); | ||
| const creditsTaken = |
There was a problem hiding this comment.
can we move this logic calculating schedule + transfer courses into one function that returns a credit value?
…urses and calculate everything transferred the calculation logic into the totalcreditsinschedule function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shireen and I added the function to calculate the total amount of transfer credit on both types of sidebars (major and non-major). We changed the parameters to take in transferCourses on the non-major sidebar. The function calculates the sum and adds it to the totalCreditsInSchedule to get creditsTaken.
For the future, maybe add AP courses on the "Add transfer courses" modal so the user doesn't have to look up the AP to NEU course transfer policies.
Closes # (issue number)
Type of change
Please tick the boxes that best match your changes.
yarn installyarn dev:migration:runChecklist: