Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coops fulfill Integrated Experience NUPath #747

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Coops fulfill Integrated Experience NUPath #747

merged 4 commits into from
Sep 22, 2024

Conversation

23langloisj
Copy link
Contributor

Description

Added an if statement where courses are assigned their NUPaths and made sure to check that if a course was a co-op, then the EX NUPath was fulfilled.

Closes # (742)

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Dragging a co-op block onto the degree planner and making sure it gives the correct nupath

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

@23langloisj 23langloisj self-assigned this Sep 14, 2024
Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 7:59pm

@@ -4,6 +4,7 @@ import {
MajorValidationResult,
PlanModel,
ScheduleCourse2,
StatusEnum,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to remove this

@@ -49,6 +49,14 @@ const NUPathSection: React.FC<NUPathSectionProps> = ({
const nupathMap: Record<string, number> = {};

for (const course of coursesTaken) {
// Check if the course is a COOP, if it is, check off the Integration Experience
if (
course.name === COOP_BLOCK.name &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good idea and it makes sense since COOP_BLOCK is a special case, but is there any way to update the structure of the COOP_BLOCK object itself to make it work?

@KobeZ123
Copy link
Contributor

OH! also make sure to change the branch name to make it relevant LOL

@23langloisj 23langloisj changed the title Jakes branch Coops fulfill Integrated Experience NUPath Sep 15, 2024
@KobeZ123 KobeZ123 self-requested a review September 22, 2024 18:10
Copy link
Contributor

@KobeZ123 KobeZ123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge!

@23langloisj 23langloisj merged commit 429f157 into main Sep 22, 2024
7 checks passed
@23langloisj 23langloisj deleted the jakes-branch branch September 22, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants