Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added link to all draggable courses #754

Merged
merged 9 commits into from
Oct 18, 2024
Merged

added link to all draggable courses #754

merged 9 commits into from
Oct 18, 2024

Conversation

denniwang
Copy link
Contributor

@denniwang denniwang commented Sep 26, 2024

Description

I added a link to all draggable courses that lead to their search page. The season and year values are hardcoded in. The fact that the course objects are draggable also makes the links un-left-clickable and needs to be right clicked>open in new tab to open.

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

image
image

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 9:06pm

still using hardcoded components :(
however, a lot of theses more accurate links lead to nothing in nusearch
@denniwang denniwang merged commit 62f0afe into main Oct 18, 2024
7 checks passed
@denniwang denniwang deleted the serachnu-urls branch October 18, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants