Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications Button #301

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Notifications Button #301

merged 3 commits into from
Dec 4, 2024

Conversation

nickpfeiffer05
Copy link
Contributor

Purpose

Added the button to take you to the subscriptions page if you are signed in

Tickets

#298

Contributors

@nickpfeiffer05

Feature List

Added notifications button which links to the subscriptions page. The button is only present when the user is signed in

Pictures

image

Reviewers

Primary reviewer:

Primary:
@ananyaspatil

Use the "Reviewers" feature in Github

Secondary reviewers:

Secondary:
@mehallhm @cherman23 @Anzhuo-W

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
searchneu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 11:14pm

Copy link
Collaborator

@ananyaspatil ananyaspatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge for now onto master. looks like adding the 'notifications' button causes the 'sign out' drop down to display off the page, this will need to be addressed before we release notifs page on prod.
image

@ananyaspatil ananyaspatil merged commit 445e7f0 into master Dec 4, 2024
5 checks passed
@ananyaspatil ananyaspatil deleted the notifications-btn branch December 4, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants