onError callback #329
Open
onError callback #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onError callback
src/LoRa.h
Outdated
| @@ -58,6 +58,7 @@ class LoRaClass : public Stream { | |||
| #ifndef ARDUINO_SAMD_MKRWAN1300 | |||
| void onReceive(void(*callback)(int)); | |||
| void onTxDone(void(*callback)()); | |||
| void onError(void(*callback)()); | |||
There was a problem hiding this comment.
I'm thinking this should be renamed to something more specific, for example: onCrcError or onReceiveCrcError.
Thoughts?
There was a problem hiding this comment.
Please name it in accordance with the rest of the repo. No objections.
There was a problem hiding this comment.
Hi @artemen if you can address these minor changes I'll merge this PR and include in the next release, which I'd like to get to this week.
Thanks for this contribution, it will add some important insight to error conditions.
|
sorry for the bit of mess. let me know if I should do a different pull request or this one will do, thanks! |
|
Do you plan to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a callback to notify user about a failed CRC packet.