Downlevel readonly array & readonly tuple #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usage telemetry from VS and VS Code shows that usage of old versions of Typescript falls off pretty fast, so there's not too much value in supporting versions before 3.4. Do you have a specific package in mind that needs to support pre-3.4 typescripts? If/when downlevel-dts gets a configurable target, as in #36, this would be worth adding. |
|
Hi there, I think this one can be updated and merged since configurable target support was added 😀 |
|
But which version it target to? 3.3? And I don't know if there is any break changes else. |
|
It targets to any below 3.4.0: semver.lt(targetVersion, "3.4.0") |
|
Updated. |
|
Is this still needed? If 3.3 usage was rare in 2020, it ought to be miniscule in 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #27.
Add some code for Compatibility of readonly array & readonly tuple before 3.4 .
It may be helpful.