Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in lock diff #616

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix bugs in lock diff #616

merged 2 commits into from
Dec 20, 2024

Conversation

psakievich
Copy link
Collaborator

The lock-diff command came out of a project that was using it in a specific way. Several bugs have been found from more general use.

Outstanding issues:

  • Multiple specs: this tool was mainly written for unified env's but compilers as deps is leading to a lot more repeated specs in the graph. Need better logic/generalization for diffing the graph
  • Testing: add some basic unit-tests so this can be expanded

@psakievich psakievich merged commit 45134f6 into main Dec 20, 2024
25 of 26 checks passed
@psakievich psakievich deleted the b/lock-diff-bugs branch December 20, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant