Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log rotation for table entities #9

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ramonitor
Copy link

Hi,

I added log rotation for Azure Table Storage based on two simple input variables that can be specified when calling createTableStorageStream.

Copy link
Owner

@sandorfr sandorfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a general level your editor has replace spaces by tabs and it pollutes the change log. I've commited and editorconfig file. Please update your PR with fixed indentation.

this.tableName = options.tableName;
this.tableService = options.tableService;

this.bootstrap();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that constructor doing heavy lifting is not a great thing. I would give the responsibility to call bootstrap to the consumer.

@sandorfr
Copy link
Owner

Thanks for that work

That's definitely a great feature but I feel like handling the rotation inside the same node process can lead to pretty bad performance. I would make it a separated feature which could be run in the same process or another one such as Azure Functions.

What do you think ?

@ramonitor
Copy link
Author

Thanks, will resubmit with correct indentation. About calling bootstrap from the consumer, maybe that’s better. I also thought about moving log rotation to Azure Functions for instance, but that requires extra setup, but maybe that is better in the end.

How do you see log rotation as a separate feature besides offloading to Azure Functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants