-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cmake packaging #11
base: master
Are you sure you want to change the base?
Improve cmake packaging #11
Conversation
…collector Fix bug in argumentscollector.
Use rand() instead of QRandomGenerator for performance reasons
SFTP upload directory make append dir path optional
Improve CMake buildsystem; fix typo
# cached variables | ||
set(QSSH_BUILD_EXAMPLES True CACHE BOOL "Build the QSsh examples.") | ||
set(BUILD_SHARED_LIBS False CACHE BOOL "Build QSsh using shared libraries.") | ||
set(BOTAN_INCLUDE_DIR "" CACHE PATH "Path of the Botan include directory. Set this if user specified BOTAN_LIBRARY location is used.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not to use find package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I checked Botan-2 does not provide .cmake files for finding package. So if I build Botan-2 manually I need a way to point QSsh to the version I have built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can provide your own Findbotan.cmake (example https://stackoverflow.com/a/72323666). botan is a thirdparty library so it should not be in main cmakelists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Could be done in a separate MR though, this one is already changing a bit.
No description provided.