Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cmake packaging #11

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

drpeterfranz
Copy link

No description provided.

# cached variables
set(QSSH_BUILD_EXAMPLES True CACHE BOOL "Build the QSsh examples.")
set(BUILD_SHARED_LIBS False CACHE BOOL "Build QSsh using shared libraries.")
set(BOTAN_INCLUDE_DIR "" CACHE PATH "Path of the Botan include directory. Set this if user specified BOTAN_LIBRARY location is used.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use find package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked Botan-2 does not provide .cmake files for finding package. So if I build Botan-2 manually I need a way to point QSsh to the version I have built.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can provide your own Findbotan.cmake (example https://stackoverflow.com/a/72323666). botan is a thirdparty library so it should not be in main cmakelists

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Could be done in a separate MR though, this one is already changing a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants