More wrapping tests; Fix ignored test #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two classes TestEMBLFeature meaning the first one and its single test were being ignored. The test also needed updated to wrap at 80 rather than 79 characters (after recent commits), and not expect a trailing newline. However, the test itself was meant to verify sanger-pathogens#50 was fixed, but didn't. The test needs changing as we do not want the long word to be split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to clashing class names, the test added in 37ed4f5 was never live. This pull request activates the test with minor updates (now wrap at 80 chars, and no trailing new line).
However, the test was intended to verify #51 had been fixed - and instead shows that line-breaks are being inserted within long words.
In my pull request #53 I suggested this:
That alone stopped the line breaks within long words, but gave overly long lines.
I've tried the combination but this does not seem to work either...
This pull request therefore just tests the current less-than-ideal behaviour, without fixing #51.