Coordinator Pattern 및 부분적인 ReactorKit 적용, 기타 코드 리팩토링 작업 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sanghyeok-kim
commented
Jul 29, 2023
sanghyeok-kim
commented
- 화면 전환 로직에 대해 Coordinator Pattern 적용
- TimerSettingViewModel, TimerSettingViewController에 대해 ReactorKit을 적용하여 각각 View, Reactor 타입으로 리팩토링
- TimerCreateViewModel, TimerCreateViewController에 대해 ReactorKit을 적용하여 각각 View, Reactor 타입으로 리팩토링
- 'TimerSetting -> TimerEditing', 'Main -> Home'으로 각각 네이밍 수정
- 커스텀 뷰의 이벤트 처리에 Relay 프로퍼티를 별도로 사용하던 방식에서 RxCocoa Traits를 사용하도록 변경
… 처리를 ControlEnvent와 Binder로 처리할 수 있도록 변경
- 네이밍과 역할을 봤을 때 ControlProperty(getter와 setter를 모두 가짐)보다는 ControlEvent(이벤트를 방출만 함)가 더 적절함
- TextField의 text에 접근하는 별도의 프로퍼티를 만들 필요 없이 rx.text를 직접 사용하면 되므로 불필요, 따라서 제거함.
…ctorKit을 이용하여 각각 View, Reactor 타입으로 리팩토링
…eactorKit을 이용하여 각각 View, Reactor 타입으로 리팩토링
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.